Fix String.dedent type

Author: slowcheetah

packages/core-js-types/src/base/proposals/string-dedent.d.ts

@@ -4,9 +4,20 @@ interface StringConstructor {
   /**
    * Template tag that removes common leading whitespace from every line in the resulting string,
    * preserving relative indentation and blank lines.
-   * @param strings The template strings array.
+   * @param template The template strings array, strings array, or a single string.
    * @param values Values to be interpolated into the template string.
    * @returns The dedented string.
    */
-  dedent(strings: TemplateStringsArray, ...values: any[]): string;
+  dedent(template: TemplateStringsArray | ArrayLike<string>, ...values: any[]): string;
+  dedent(template: { raw: readonly string[] }, ...values: any[]): string;
+  dedent(template: string): string;
+}
+
+interface String {
+  /**
+   * Template tag that removes common leading whitespace from every line in the resulting string,
+   * preserving relative indentation and blank lines.
+   * @returns The dedented string.
+   */
+  dedent(): string;
 }

packages/core-js-types/src/base/pure/proposals/string-dedent.d.ts

@@ -0,0 +1,32 @@
+/// <reference types="../../core-js-types/string-base.d.ts" />
+
+// Motivation: We should use String without the matchAll method to avoid signature conflicts
+
+// https://github.com/tc39/proposal-string-dedent
+
+declare namespace CoreJS {
+  export interface CoreJSStringConstructor extends StringConstructor {
+
+    /**
+     * Template tag that removes common leading whitespace from every line in the resulting string,
+     * preserving relative indentation and blank lines.
+     * @param template The template strings array, strings array, or a single string.
+     * @param values Values to be interpolated into the template string.
+     * @returns The dedented string.
+     */
+    dedent(template: TemplateStringsArray | ArrayLike<string>, ...values: any[]): string;
+    dedent(template: { raw: readonly string[] }, ...values: any[]): string;
+    dedent(template: string): string;
+  }
+
+  var CoreJSString: CoreJSStringConstructor;
+
+  export interface CoreJSString extends StringBase {
+    /**
+     * Template tag that removes common leading whitespace from every line in the resulting string,
+     * preserving relative indentation and blank lines.
+     * @returns The dedented string.
+     */
+    dedent(): string;
+  }
+}

tests/type-definitions/global/proposals/string-dedent.test.ts

@@ -8,9 +8,9 @@ const rdedent2: string = String.dedent`line1
 const tpl = Object.assign(['foo', 'bar'], { raw: ['foo', 'bar'] }) as TemplateStringsArray;
 String.dedent(tpl, 1, 2);
 
-// @ts-expect-error
-String.dedent(['foo', 'bar'], 1, 2);
-// @ts-expect-error
-String.dedent('foo', 1, 2);
+String.dedent({ raw: ["a\n  b\n", "\n  c\n"] }, 1, 2);
+
+'string\ndedent'.dedent();
+
 // @ts-expect-error
 String.dedent();

tests/type-definitions/pure/proposals/string-dedent.test.ts

@@ -8,9 +8,7 @@ const rdedent2: string = stringDedent`line1
 const tpl = Object.assign(['foo', 'bar'], { raw: ['foo', 'bar'] }) as TemplateStringsArray;
 stringDedent(tpl, 1, 2);
 
-// @ts-expect-error
-stringDedent(['foo', 'bar'], 1, 2);
-// @ts-expect-error
-stringDedent('foo', 1, 2);
+stringDedent({ raw: ["a\n  b\n", "\n  c\n"] }, 1, 2);
+
 // @ts-expect-error
 stringDedent();