Skip to content

Commit fe5596c

Browse files
committed
add some missed asserts
1 parent 04016f5 commit fe5596c

File tree

8 files changed

+20
-2
lines changed

8 files changed

+20
-2
lines changed

tests/unit-global/es.map.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,7 @@ QUnit.test('Map#@@iterator', assert => {
439439
assert.arity(Map.prototype.entries, 0);
440440
assert.looksNative(Map.prototype[Symbol.iterator]);
441441
assert.same(Map.prototype[Symbol.iterator], Map.prototype.entries);
442+
assert.nonEnumerable(Map.prototype, Symbol.iterator);
442443
const map = new Map();
443444
map.set('a', 'q');
444445
map.set('s', 'w');

tests/unit-global/es.weak-set.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ QUnit.test('WeakSet#add', assert => {
7979

8080
QUnit.test('WeakSet#delete', assert => {
8181
assert.isFunction(WeakSet.prototype.delete);
82-
if (NATIVE) assert.arity(WeakSet.prototype.delete, 1);
82+
assert.arity(WeakSet.prototype.delete, 1);
83+
if (NATIVE) assert.name(WeakSet.prototype.delete, 'delete');
8384
assert.looksNative(WeakSet.prototype.delete);
8485
assert.nonEnumerable(WeakSet.prototype, 'delete');
8586
const a = {};

tests/unit-pure/es.array.find-index.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,7 @@ QUnit.test('Array#findIndex', assert => {
1818
assert.throws(() => findIndex(null, 0), TypeError);
1919
assert.throws(() => findIndex(undefined, 0), TypeError);
2020
}
21+
assert.notThrows(() => findIndex({ length: -1, 0: 1 }, () => {
22+
throw new Error();
23+
}), 'uses ToLength');
2124
});

tests/unit-pure/es.array.find.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,7 @@ QUnit.test('Array#find', assert => {
1818
assert.throws(() => find(null, 0), TypeError);
1919
assert.throws(() => find(undefined, 0), TypeError);
2020
}
21+
assert.notThrows(() => find({ length: -1, 0: 1 }, () => {
22+
throw new Error();
23+
}), 'uses ToLength');
2124
});

tests/unit-pure/es.array.slice.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { GLOBAL } from '../helpers/constants.js';
1+
import { GLOBAL, STRICT } from '../helpers/constants.js';
22

33
import Symbol from 'core-js-pure/es/symbol';
44
import isArray from 'core-js-pure/es/array/is-array';
@@ -24,6 +24,10 @@ QUnit.test('Array#slice', assert => {
2424
if (list) {
2525
assert.notThrows(() => isArray(slice(list)), 'works with NodeList');
2626
}
27+
if (STRICT) {
28+
assert.throws(() => slice(null), TypeError);
29+
assert.throws(() => slice(undefined), TypeError);
30+
}
2731
array = [];
2832
// eslint-disable-next-line object-shorthand -- constructor
2933
array.constructor = { [Symbol.species]: function () {

tests/unit-pure/es.promise.reject.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import Promise from 'core-js-pure/es/promise';
33
QUnit.test('Promise.reject', assert => {
44
const { reject } = Promise;
55
assert.isFunction(reject);
6+
assert.arity(reject, 1);
67
assert.name(reject, 'reject');
78
});
89

tests/unit-pure/esnext.array.filter-out.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ QUnit.test('Array#filterOut', assert => {
2020
assert.throws(() => filterOut(null, () => { /* empty */ }), TypeError);
2121
assert.throws(() => filterOut(undefined, () => { /* empty */ }), TypeError);
2222
}
23+
assert.notThrows(() => filterOut({ length: -1, 0: 1 }, () => {
24+
throw new Error();
25+
}), 'uses ToLength');
2326
array = [];
2427
// eslint-disable-next-line object-shorthand -- constructor
2528
array.constructor = { [Symbol.species]: function () {

tests/unit-pure/esnext.math.fscale.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { createConversionChecker } from '../helpers/helpers.js';
22

3+
import fround from 'core-js-pure/full/math/fround';
34
import fscale from 'core-js-pure/full/math/fscale';
45

56
QUnit.test('Math.fscale', assert => {
@@ -10,6 +11,7 @@ QUnit.test('Math.fscale', assert => {
1011
assert.same(fscale(0, 3, 5, 8, 10), 5);
1112
assert.same(fscale(1, 1, 1, 1, 1), NaN);
1213
assert.same(fscale(-1, -1, -1, -1, -1), NaN);
14+
assert.same(fscale(3, 1, 2, 1, Math.PI), fround((3 - 1) * (Math.PI - 1) / (2 - 1) + 1));
1315

1416
const checker1 = createConversionChecker(3);
1517
const checker2 = createConversionChecker(1);

0 commit comments

Comments
 (0)