You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bump wasm-cxx-shim to v0.4.0 + manifold pin to 3ce9622b
Shim's v0.4.0 dropped the iostream carry-patch (upstream manifold#1690
merged) and moved its tested pin to upstream master `3ce9622b`. We pin
host to the same commit so the wasm-uu lane and host build see the
same C API surface.
No version bump — sys/safe versions stay at 3.4.107 / 0.1.8 (already
pre-bumped, not yet released).
Verified:
- All 222 host integration tests pass against the new manifold pin
- wasm-uu CI-equivalent build clean, produced wasm has zero unexpected
imports
- 13 playground node tests pass against the new build
- cargo fmt + clippy clean
Copy file name to clipboardExpand all lines: CLAUDE.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -49,7 +49,7 @@ The sys crate clones manifold3d (pinned to a specific commit on master, post-v3.
49
49
50
50
Things to revisit whenever the manifold pin moves OR `wasm-cxx-shim` cuts a new release:
51
51
52
-
-**Re-evaluate wasm32-unknown-unknown cfg-gates.** Any FFI declaration / safe wrapper / test gated on `not(all(target_arch = "wasm32", target_os = "unknown"))` exists because that surface postdates the shim's tested manifold pin. When the shim's tested pin moves up to (or past) our host pin, those gates can be dropped and the surface unified across targets. Current gated surface: `manifold_*_obj` (OBJ I/O — gated for a different reason: iostream patches strip it; this stays regardless). Ray casting is **no longer gated** as of shim v0.4.0-alpha.1, whose tested pin matches our host pin. Grep for `target_os = "unknown"` to enumerate.
52
+
-**Re-evaluate wasm32-unknown-unknown cfg-gates.** Any FFI declaration / safe wrapper / test gated on `not(all(target_arch = "wasm32", target_os = "unknown"))` exists because that surface postdates the shim's tested manifold pin. When the shim's tested pin moves up to (or past) our host pin, those gates can be dropped and the surface unified across targets. Current gated surface: `manifold_*_obj` (OBJ I/O — gated for a different reason: iostream patches strip it; this stays regardless). The shim's tested pin currently matches our host pin (no extra gating needed). Grep for `target_os = "unknown"` to enumerate.
53
53
-**Re-evaluate carry-patches.** For each patch in `crates/manifold-csg-sys/patches/` (if any), check whether it's merged upstream and included in the new pin; if so, delete it.
0 commit comments