Skip to content

Commit acc970a

Browse files
committed
Fix typo in consts.js, text cleanup
1 parent 358537a commit acc970a

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

lib/consts.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module.exports = {
99
// how often to clear expired messages
1010
GC_INTERVAL: 15 * 60 * 1000,
1111

12-
// artificail delay between deleting next expired message in ms
12+
// artificial delay between deleting next expired message in ms
1313
// set to 0 to disable
1414
GC_DELAY_DELETE: 0,
1515

@@ -146,7 +146,7 @@ module.exports = {
146146
// Number of mailbox subpaths in a single mailbox path
147147
MAX_SUB_MAILBOXES: 128,
148148

149-
// S/MIME encryption defaults AES-CBC + PKCS#1 v1.5 for maximum client compatibility.
149+
// S/MIME encryption defaults - AES-CBC + PKCS#1 v1.5 for maximum client compatibility.
150150
// Both are legacy and potentially vulnerable.
151151
// Prefer AES-GCM + OAEP for modern deployments with capable clients.
152152
SMIME_DEFAULT_CIPHER: 'AES-CBC',

test/kdf-x963-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ const SMIMEEncryptor = require('../lib/smime');
88
const kdfX963 = SMIMEEncryptor._kdfX963;
99

1010
// ---------------------------------------------------------------------------
11-
// NIST CAVP test vectors (CAVS 12.0) ANS X9.63-2001 KDF, SHA-256
11+
// NIST CAVP test vectors (CAVS 12.0) - ANS X9.63-2001 KDF, SHA-256
1212
// Source: https://github.com/pyca/cryptography/blob/main/vectors/cryptography_vectors/KDF/ansx963_2001.txt
1313
// ---------------------------------------------------------------------------
1414

15-
describe('kdfX963 NIST CAVP vectors (SHA-256)', function () {
15+
describe('kdfX963 - NIST CAVP vectors (SHA-256)', function () {
1616
// [SHA-256] [shared secret length = 192] [SharedInfo length = 0] [key data length = 128]
1717
// Single-block derivation, no SharedInfo
1818
describe('single block, no SharedInfo (128-bit output)', function () {
@@ -132,7 +132,7 @@ describe('kdfX963 — NIST CAVP vectors (SHA-256)', function () {
132132
// Misuse and edge-case tests
133133
// ---------------------------------------------------------------------------
134134

135-
describe('kdfX963 misuse and edge cases', function () {
135+
describe('kdfX963 - misuse and edge cases', function () {
136136
it('should return an empty buffer when keyLength is 0', function () {
137137
let z = Buffer.from('aabbccdd', 'hex');
138138
let result = kdfX963(z, 0, Buffer.alloc(0));

test/smime-encrypt-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ describe('S/MIME encryption', function () {
287287
expect(Buffer.compare(decryptedBuf, rawCopy)).to.equal(0);
288288
});
289289

290-
// EC key tests GCM (AuthEnvelopedData)
290+
// EC key tests - GCM (AuthEnvelopedData)
291291
for (let curve of ['P-256', 'P-384', 'P-521']) {
292292
it(`GCM: should encrypt and decrypt with EC ${curve} certificate`, async function () {
293293
let raw = makeMessage({});
@@ -309,7 +309,7 @@ describe('S/MIME encryption', function () {
309309
});
310310
}
311311

312-
// EC key tests CBC (EnvelopedData via pkijs)
312+
// EC key tests - CBC (EnvelopedData via pkijs)
313313
for (let curve of ['P-256', 'P-384', 'P-521']) {
314314
it(`CBC: should encrypt and decrypt with EC ${curve} certificate`, async function () {
315315
let raw = makeMessage({});
@@ -331,7 +331,7 @@ describe('S/MIME encryption', function () {
331331
});
332332
}
333333

334-
// RSA size variants GCM
334+
// RSA size variants - GCM
335335
for (let bits of [2048, 3072, 4096]) {
336336
it(`GCM: should encrypt and decrypt with RSA ${bits} certificate`, async function () {
337337
let raw = makeMessage({});
@@ -351,7 +351,7 @@ describe('S/MIME encryption', function () {
351351
});
352352
}
353353

354-
// RSA size variants CBC
354+
// RSA size variants - CBC
355355
for (let bits of [2048, 3072, 4096]) {
356356
it(`CBC: should encrypt and decrypt with RSA ${bits} certificate`, async function () {
357357
let raw = makeMessage({});

0 commit comments

Comments
 (0)