refactor(locale): simplify visibility lookup and align shell locale API

Author: zouyonghe

src-tauri/src/desktop_bridge_commands.rs

@@ -154,9 +154,10 @@ pub(crate) fn desktop_bridge_set_shell_locale(
     app_handle: AppHandle,
     locale: Option<String>,
 ) -> BackendBridgeResult {
+    let packaged_root_dir = runtime_paths::default_packaged_root_dir();
     match shell_locale::write_cached_shell_locale(
         locale.as_deref(),
-        runtime_paths::default_packaged_root_dir(),
+        packaged_root_dir.as_deref(),
     ) {
         Ok(()) => {
             tray_labels::update_tray_menu_labels(
@@ -169,9 +170,12 @@ pub(crate) fn desktop_bridge_set_shell_locale(
                 reason: None,
             }
         }
-        Err(error) => BackendBridgeResult {
-            ok: false,
-            reason: Some(error),
-        },
+        Err(error) => {
+            append_desktop_log(&format!("failed to persist shell locale: {error}"));
+            BackendBridgeResult {
+                ok: false,
+                reason: Some(error),
+            }
+        }
     }
 }

src-tauri/src/shell_locale.rs

@@ -96,9 +96,9 @@ fn read_cached_shell_locale(packaged_root_dir: Option<&Path>) -> Option<&'static
 
 pub(crate) fn write_cached_shell_locale(
     locale: Option<&str>,
-    packaged_root_dir: Option<PathBuf>,
+    packaged_root_dir: Option<&Path>,
 ) -> Result<(), String> {
-    let Some(state_path) = desktop_state_path_for_locale(packaged_root_dir.as_deref()) else {
+    let Some(state_path) = desktop_state_path_for_locale(packaged_root_dir) else {
         return Ok(());
     };
 

src-tauri/src/tray_labels.rs

@@ -41,11 +41,14 @@ pub fn update_tray_menu_labels_with_visibility<F>(
         runtime_paths::default_packaged_root_dir(),
     );
     let shell_texts = shell_locale::shell_texts_for_locale(locale);
-    let window_visibility = app_handle
-        .get_webview_window("main")
-        .and_then(|window| window.is_visible().ok());
-    let is_visible = window_visibility.unwrap_or(true);
-    let effective_visible = visible_override.unwrap_or(is_visible);
+    let effective_visible = if let Some(visible) = visible_override {
+        visible
+    } else {
+        app_handle
+            .get_webview_window("main")
+            .and_then(|window| window.is_visible().ok())
+            .unwrap_or(true)
+    };
 
     let toggle_label = if effective_visible {
         shell_texts.tray_hide