Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anax v3.0 profiletypes cli #4183

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Anax v3.0 profiletypes cli #4183

merged 7 commits into from
Feb 20, 2025

Conversation

anaxceron
Copy link
Collaborator

Describe your pull request here: Documenting the profile types and properties in team config. Addressing Issue 3526.

List the file(s) included in this PR: docs\user-guide\cli-using-editing-team-configuration.md

After creating the PR, follow the instructions in the comments.

anaxceron and others added 3 commits February 13, 2025 13:30
@anaxceron anaxceron added area: cli This issue is related to Zowe Command Line Interface (CLI) release: V3 Zowe V3 content review: sme Needs review by an SME labels Feb 19, 2025
@anaxceron anaxceron self-assigned this Feb 19, 2025
@github-actions GitHub Actions
Copy link

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these steps.

  • Add the label review: sme if an SME needs to check your content.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Link any Doc Issues related to this PR.
  • Fix broken links found in your content areas.
  • Notify the SME to review this PR (if applicable).
  • Merge to the master branch if your PR updates content that is on the live site. Merge to docs-staging if your PR updates content for a future release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

🚀 Deployed on https://67b742268a59702a6b153baa--zowe-docs-master.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 19, 2025 18:54 Inactive
sbohnert
sbohnert approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@sbohnert sbohnert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@anaxceron anaxceron linked an issue Feb 19, 2025 that may be closed by this pull request
Documenting all profile types, properties in Zowe CLI content #3526
Closed
@github-actions github-actions bot temporarily deployed to pull request February 19, 2025 20:31 Inactive
@adam-wolfe
Copy link
Collaborator

adam-wolfe commented Feb 19, 2025 •
edited
Loading

Wondering if it makes sense to put this in the Benefits of team configuration section vs just putting it under Using team configuration.

Not really something that needs to be addressed in this PR, but it seems like it would make more sense to move some of these articles out of Benefits of team configuration since some of them are more related to basic usage of team config.

image

@anaxceron
Copy link
Collaborator Author

Wondering if it makes sense to put this in the Benefits of team configuration section vs just putting it under Using team configuration.

Not really something that needs to be addressed in this PR, but it seems like it would make more sense to move some of these articles out of Benefits of team configuration since some of them are more related to basic usage of team config.

image

I think this section needs a re-organization. I agree to pursue this w/ a different issue/pr.

@anaxceron
edited based on feedback
eb446aa 
Signed-off-by: anaxceron <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request February 20, 2025 14:55 Inactive
zFernand0
zFernand0 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

This looks amazing! 🙏

docs/user-guide/cli-using-editing-team-configuration.md
| rejectUnauthorized | Reject self-signed certificates.<br/><br/>**Default**: ```true``` | **boolean**:<br/> ```true```<br/>```false``` |
| tokenType | The type of token to get and use for the API. Omit this option to use the default token type, which is provided by `zowe auth login`. | string |
| tokenValue | The value of the token to pass to the API. | string |
| certFile | The file path to a certificate file to use for authentication. <br/> <br/> Note: <br/> The CLI does not support certificate files that require a password. For more information, see [PEM certificate files](../troubleshoot/cli/troubleshoot-cli-credentials.md#pem-certificate-files). | string |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider opening an issue with the corresponding plug-in (or CLI in this case) for every update that you had to make manually.
(unless you'd want to have the script enhanced) 🙏

adam-wolfe
adam-wolfe approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @anaxceron and @zFernand0

@anaxceron anaxceron merged commit 430d116 into master Feb 20, 2025
3 of 4 checks passed
@anaxceron anaxceron deleted the anax-v3.0-profiletypes-cli branch February 20, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zFernand0 zFernand0 zFernand0 approved these changes

@sbohnert sbohnert sbohnert approved these changes

@adam-wolfe adam-wolfe adam-wolfe approved these changes

Assignees

@anaxceron anaxceron

Labels
area: cli This issue is related to Zowe Command Line Interface (CLI) release: V3 Zowe V3 content review: sme Needs review by an SME
Projects
Zowe CLI Squad
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documenting all profile types, properties in Zowe CLI content
4 participants
@anaxceron @adam-wolfe @zFernand0 @sbohnert