tests: cases for default cred mgr and AppSettings

Signed-off-by: Trae Yelovich <[email protected]>

Author: traeok

packages/imperative/src/security/__tests__/DefaultCredentialManager.unit.test.ts

@@ -15,7 +15,7 @@ import { Module } from "module";
 import { DefaultCredentialManager } from "..";
 import { keyring as keytar } from "@zowe/secrets-for-zowe-sdk";
 import { ImperativeError } from "../../error";
-import { PersistenceValue } from "../src/doc/IDefaultCredentialManagerOptions";
+import { PersistenceLevel, PersistenceValue } from "../src/doc/IDefaultCredentialManagerOptions";
 
 const winMaxCredentialLength = 2560;
 
@@ -31,6 +31,49 @@ describe("DefaultCredentialManager", () => {
         expect((manager as any).service).toEqual(service);
     });
 
+    describe("constructor switch statement", () => {
+        it("should set persistValueWin32 to SessionOnly when persist option is SessionOnly", () => {
+            const service = "imperative";
+            const manager = new DefaultCredentialManager(service, "test manager", {
+                persist: PersistenceLevel.SessionOnly
+            });
+
+            expect((manager as any).persistValueWin32).toEqual(PersistenceValue.SessionOnly);
+        });
+
+        it("should set persistValueWin32 to LocalMachine when persist option is LocalMachine", () => {
+            const service = "imperative";
+            const manager = new DefaultCredentialManager(service, "test manager", {
+                persist: PersistenceLevel.LocalMachine
+            });
+
+            expect((manager as any).persistValueWin32).toEqual(PersistenceValue.LocalMachine);
+        });
+
+        it("should set persistValueWin32 to Enterprise when persist option is Enterprise", () => {
+            const service = "imperative";
+            const manager = new DefaultCredentialManager(service, "test manager", {
+                persist: PersistenceLevel.Enterprise
+            });
+
+            expect((manager as any).persistValueWin32).toEqual(PersistenceValue.Enterprise);
+        });
+
+        it("should default to Enterprise when no persist option is provided", () => {
+            const service = "imperative";
+            const manager = new DefaultCredentialManager(service, "test manager");
+
+            expect((manager as any).persistValueWin32).toEqual(PersistenceValue.Enterprise);
+        });
+
+        it("should default to Enterprise when options object is undefined", () => {
+            const service = "imperative";
+            const manager = new DefaultCredentialManager(service, "test manager", undefined);
+
+            expect((manager as any).persistValueWin32).toEqual(PersistenceValue.Enterprise);
+        });
+    });
+
     describe("instance methods", () => {
         const service = DefaultCredentialManager.SVC_NAME;
 

packages/imperative/src/settings/__tests__/AppSettings.unit.test.ts

@@ -169,6 +169,73 @@ describe("AppSettings", () => {
         });
     });
 
+    describe("set", () => {
+        beforeEach(() => {
+            jest.spyOn(JSONSettingsFilePersistence.prototype, "read").mockReturnValueOnce({
+                overrides: {
+                    CredentialManager: "@zowe/cli"
+                }
+            });
+            AppSettings.initialize("file", defaultSettings);
+        });
+
+        it("sets a property in credentialManagerOptions with the given key/value pair", () => {
+            expect(() => AppSettings.instance.set("credentialManagerOptions", "persist", PersistenceLevel.LocalMachine)).not.toThrow();
+        });
+
+        it("throws an error if the given namespace does not exist", () => {
+            expect(() => AppSettings.instance.set("nonexistent" as any, "blah", 123)).toThrow("Namespace nonexistent does not exist");
+        });
+    });
+
+    describe("get", () => {
+        beforeEach(() => {
+            jest.spyOn(JSONSettingsFilePersistence.prototype, "read").mockReturnValueOnce({
+                overrides: {
+                    CredentialManager: false,
+                },
+                credentialManagerOptions: {}
+            });
+            AppSettings.initialize("file", defaultSettings);
+        });
+
+        it("throws an error if the given namespace does not exist", () => {
+            expect(() => AppSettings.instance.get("asdfghjkl" as any, "nonexistent_key")).toThrow("Namespace asdfghjkl does not exist");
+        });
+        
+        it("returns a property in credentialManagerOptions namespace when options are present", () => {
+            AppSettings.instance.set("credentialManagerOptions", "persist", PersistenceLevel.LocalMachine);
+            expect(AppSettings.instance.get("credentialManagerOptions", "persist")).not.toBeUndefined();
+            expect(AppSettings.instance.get("credentialManagerOptions", "persist")).toStrictEqual(PersistenceLevel.LocalMachine);
+        });
+
+        it("returns undefined for a credentialManagerOptions property when no options are present", () => {
+            expect(AppSettings.instance.get("credentialManagerOptions", "persist")).toBeUndefined();
+        });
+    });
+
+    describe("getNamespace", () => {
+        beforeEach(() => {
+            jest.spyOn(JSONSettingsFilePersistence.prototype, "read").mockReturnValueOnce({
+                overrides: {
+                    CredentialManager: false
+                }
+            });
+            AppSettings.initialize("file", defaultSettings);
+        });
+
+        it("returns the object for overrides namespace", () => {
+            expect(AppSettings.instance.getNamespace("overrides")).not.toBeUndefined();
+            expect(AppSettings.instance.getNamespace("overrides")).toStrictEqual(defaultSettings.overrides);
+        });
+
+        it("returns the namespace for credentialManagerOptions when options are present", () => {
+            AppSettings.instance.set("credentialManagerOptions", "persist", PersistenceLevel.LocalMachine);
+            expect(AppSettings.instance.getNamespace("credentialManagerOptions")).not.toBeUndefined();
+            expect(AppSettings.instance.getNamespace("credentialManagerOptions")).toStrictEqual({ persist: PersistenceLevel.LocalMachine });
+        });
+    });
+
     describe("writing settings", () => {
         /**
          * Takes an app settings object and mocks the {@link IAppSettingsAllMethods#writeSettingsFile} method