Skip to content

Commit 6079197

Browse files
committed
fix: address SonarCloud issues
Signed-off-by: Trae Yelovich <[email protected]>
1 parent 7e0ee5e commit 6079197

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/imperative/src/security/src/CredentialManagerOverride.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ export class CredentialManagerOverride {
236236
public static getCredentialManagerOptions(): ICredentialManagerOptions {
237237
try {
238238
const settings = this.getSettingsFileJson();
239-
return settings.json.credentialManagerOptions as Record<string, unknown> ?? {};
239+
return settings.json.credentialManagerOptions ?? {};
240240
} catch {
241241
return {};
242242
}
@@ -263,7 +263,7 @@ export class CredentialManagerOverride {
263263
const cachedSettings = AppSettings.instance.getSettings();
264264
cachedSettings.overrides.CredentialManager = updatedSettings.overrides.CredentialManager;
265265
cachedSettings.credentialManagerOptions = updatedSettings.credentialManagerOptions ?
266-
{ ...updatedSettings.credentialManagerOptions as Record<string, unknown> } : {};
266+
{ ...updatedSettings.credentialManagerOptions } : {};
267267
}
268268

269269
//________________________________________________________________________

packages/imperative/src/settings/src/AppSettings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { JSONSettingsFilePersistence } from "./persistance/JSONSettingsFilePersi
1818
import { IO } from "../../io";
1919
import { ImperativeError } from "../../error";
2020

21-
type SettingValue = false | string | number | boolean | Record<string, unknown>;
21+
type SettingValue = string | number | boolean | Record<string, unknown>;
2222

2323
/**
2424
* This class represents settings for an Imperative CLI application that can be configured

0 commit comments

Comments
 (0)