refactor: only run persist logic when platform is win32

Signed-off-by: Trae Yelovich <[email protected]>

Author: traeok

packages/imperative/src/security/__tests__/DefaultCredentialManager.unit.test.ts

@@ -16,6 +16,7 @@ import { DefaultCredentialManager } from "..";
 import { keyring as keytar } from "@zowe/secrets-for-zowe-sdk";
 import { ImperativeError } from "../../error";
 import { PersistenceLevel, PersistenceValue } from "../src/doc/IDefaultCredentialManagerOptions";
+import { Logger } from "../../logger";
 
 const winMaxCredentialLength = 2560;
 
@@ -72,6 +73,14 @@ describe("DefaultCredentialManager", () => {
 
             expect((manager as any).persistValueWin32).toEqual(PersistenceValue.Enterprise);
         });
+        
+        it("should log warning when given persistence level is invalid", () => {
+            const service = "imperative";
+            const loggerWarnSpy = jest.spyOn(Logger.prototype, "warn");
+            const manager = new DefaultCredentialManager(service, "test manager", { persist: "invalid_value" as any });
+            expect((manager as any).persistValueWin32).toEqual(PersistenceValue.Enterprise);
+            expect(loggerWarnSpy).toHaveBeenCalledWith("[DefaultCredentialManager] Win32 persistence option is invalid, falling back to enterprise.");
+        });
     });
 
     describe("instance methods", () => {

packages/imperative/src/security/src/DefaultCredentialManager.ts

@@ -96,22 +96,25 @@ export class DefaultCredentialManager extends AbstractCredentialManager {
         // constructor doesn't do anything. Who knows what things might happen in
         // the abstract class initialization in the future.
         super(service, displayName, options);
-        switch (options?.persist) {
-            case PersistenceLevel.SessionOnly:
-                this.persistValueWin32 = PersistenceValue.SessionOnly;
-                break;
-            case PersistenceLevel.LocalMachine:
-                this.persistValueWin32 = PersistenceValue.LocalMachine;
-                break;
-            case PersistenceLevel.Enterprise:
-                this.persistValueWin32 = PersistenceValue.Enterprise;
-                break;
-            default:
-                break;
-        }
 
-        if (process.platform === "win32") {
-            Logger.getImperativeLogger().trace(`[DefaultCredentialManager] Persistence level (win32): ${options?.persist ?? PersistenceLevel.Enterprise}`);
+        if (process.platform === "win32") {    
+            switch (options?.persist) {
+                case PersistenceLevel.SessionOnly:
+                    this.persistValueWin32 = PersistenceValue.SessionOnly;
+                    break;
+                case PersistenceLevel.LocalMachine:
+                    this.persistValueWin32 = PersistenceValue.LocalMachine;
+                    break;
+                case PersistenceLevel.Enterprise:
+                    this.persistValueWin32 = PersistenceValue.Enterprise;
+                    break;
+                default:
+                    if (options?.persist) {
+                        Logger.getImperativeLogger().warn("[DefaultCredentialManager] Win32 persistence option is invalid, falling back to enterprise.");
+                    }
+                    break;
+            }
+            Logger.getImperativeLogger().trace(`[DefaultCredentialManager] Persistence level received (win32): ${options?.persist ?? PersistenceLevel.Enterprise}`);
         }
 
         /* Gather all services. We will load secure properties for the first