Various issues on Download.allDataSets

[JWaters02]

Describe the bug

Bugs:

1. Preserve original letter case option supplied does not preserve case (i.e. all caps) for directory names on download data sets matching/allDatasets command. The file names themselves are preserved though.
2. "4 data set(s) downloaded successfully to ./" ./ is technically correct I guess but it doesn't really make sense. It should just not show if --directory is not supplied to be consistent with all the other commands...
3. Sequential data set is not downloaded to the correct folder (if --directory is not supplied) and has wrong name. It should be next to the other PDSes but it is actually on the same level as the HLQ (see results).
4. When outputting member names ("Members:") in the dsorg status, is there a reason for the list being appended with a semi colon?

Expected and actual results

Z02589.SPDS should be here under z02589 folder and be called just SDPS.txt

Describe your environment

• Zowe CLI version installed (run command zowe --version): 8.27.1
• Installed plug-ins and their version numbers (run command zowe plugins list --short): N/A
• Node.js and NPM versions installed (run node --version, npm --version): v20.11.1, 10.8.3
• Environment variables in use: N/A
• Operating system and version: Win10 22H2
• Shell/terminal (bash, cmd, powershell, etc...): cmd

Additional context

I'm working on download API stuff anyway so I can probably take point on this (if you could assign me to the issue as well, thanks)

[github-actions]

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

[t1m0thyj]

@JWaters02 Thanks for investigating the APIs, these are all good catches 🙂

1. Preserve original letter case option supplied does not preserve case (i.e. all caps) for directory names on download data sets matching/allDatasets command. The file names themselves are preserved though.

Not too familiar with the preserve case setting so I was unsure if it applies just to USS files, or also to data sets. Since you mentioned it affects file names, I would agree it should apply to directory names as well.

2. "4 data set(s) downloaded successfully to ./" ./ is technically correct I guess but it doesn't really make sense. It should just not show if --directory is not supplied to be consistent with all the other commands...

I assume the intent would be to keep the "X data set(s) downloaded successfully" message, just without the suffix at the end?

3. Sequential data set is not downloaded to the correct folder (if --directory is not supplied) and has wrong name. It should be next to the other PDSes but it is actually on the same level as the HLQ (see results).

Not sure I agree with categorizing this as a bug - I can see where you're coming from because when downloading data sets in bulk, it would be nice to have the directory structure match for all of them. However, this may have been an intentional decision and changing it could be considered breaking. Curious to get more thoughts on this @adam-wolfe @gejohnston @zFernand0

4. When outputting member names ("Members:") in the dsorg status, is there a reason for the list being appended with a semi colon?

I don't think so, that looks like a typo to me 😁

[JWaters02]

I don't think so, that looks like a typo to me 😁

lol same, just wondered if maybe it was intentional because there are test cases written with the semi-colon in it, making it at least seem like a conscious decision...