testing

Signed-off-by: Amber <[email protected]>

Author: ATorrise

packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetTree.unit.test.ts

@@ -179,6 +179,15 @@ function createGlobalMocks() {
     return globalMocks;
 }
 
+function makeDefaultMvsApi() {
+    return {
+        dataSet: jest.fn().mockResolvedValue({ apiResponse: { items: [] } }),
+        allMembers: jest.fn().mockResolvedValue({ apiResponse: { items: [] } }),
+        createDataSet: jest.fn().mockResolvedValue({ apiResponse: {} }),
+        createDataSetMember: jest.fn().mockResolvedValue({ apiResponse: {} }),
+    };
+}
+
 describe("Dataset Tree Unit Tests - Initialisation", () => {
     function createBlockMocks() {
         const session = createISession();
@@ -5143,13 +5152,23 @@ describe("DataSetTree Unit Tests - Function handleDrop", () => {
 
 describe("DatasetTree.handleDrop - blocking behavior", () => {
     let dsTree: DatasetTree;
+    let originalGetMvsApiInDatasetTests: any;
 
     beforeEach(() => {
         jest.resetAllMocks();
         jest.clearAllMocks();
         dsTree = new DatasetTree();
+        jest.spyOn(ZoweExplorerApiRegister as any, "getMvsApi").mockImplementation(() => makeDefaultMvsApi());
+        originalGetMvsApiInDatasetTests = (ZoweExplorerApiRegister as any).getMvsApi;
+        (ZoweExplorerApiRegister as any).getMvsApi = jest.fn();
+    });
+
+    afterEach(() => {
+        (ZoweExplorerApiRegister as any).getMvsApi = originalGetMvsApiInDatasetTests;
+        jest.restoreAllMocks();
     });
 
+
     function makeDraggedPdsNode(dsn: string, session: any, profile: any) {
         const sessionNode = createDatasetSessionNode(session, profile);
         const pdsNode = new ZoweDatasetNode({

packages/zowe-explorer/__tests__/__unit__/trees/shared/SharedUtils.unit.test.ts

@@ -28,6 +28,7 @@ import { ZoweUSSNode } from "../../../../src/trees/uss/ZoweUSSNode";
 import { MockedProperty } from "../../../__mocks__/mockUtils";
 import { createIJobFile, createJobSessionNode } from "../../../__mocks__/mockCreators/jobs";
 import { JobFSProvider } from "../../../../src/trees/job/JobFSProvider";
+import { ZoweExplorerApiRegister } from "../../../../src/extending/ZoweExplorerApiRegister";
 
 jest.mock("../../../../src/tools/ZoweLocalStorage");
 
@@ -59,6 +60,27 @@ function createGlobalMocks() {
     return newMocks;
 }
 
+function makeFakeMvsApiForDataSet(items: any[] = []) {
+    return {
+        dataSet: jest.fn().mockResolvedValue({ apiResponse: { items } }),
+        // include allMembers too in case other tests call it
+        allMembers: jest.fn().mockResolvedValue({ apiResponse: { items: [] } }),
+    };
+}
+
+function makeFakeMvsApi(items: any[] = []) {
+    return {
+        dataSet: jest.fn().mockResolvedValue({ apiResponse: { items } }),
+        allMembers: jest.fn().mockResolvedValue({ apiResponse: { items: [] } }),
+    };
+}
+
+beforeEach(() => {
+    jest.resetAllMocks();
+    jest.clearAllMocks();
+    jest.spyOn(ZoweExplorerApiRegister as any, "getMvsApi").mockImplementation(() => makeFakeMvsApi());
+});
+
 describe("Shared Utils Unit Tests - Function node.concatChildNodes()", () => {
     it("Checks that concatChildNodes returns the proper array of children", async () => {
         const globalMocks = createGlobalMocks();
@@ -1517,13 +1539,18 @@ describe("SharedUtils.handleProfileChange", () => {
 
 describe("SharedUtils helpers", () => {
     const mockGetMvsApi = jest.fn();
+    let originalGetMvsApi: any;
 
     beforeEach(() => {
         jest.resetAllMocks();
         jest.clearAllMocks();
+
+        originalGetMvsApi = (ZoweExplorerApiRegister as any).getMvsApi;
+        (ZoweExplorerApiRegister as any).getMvsApi = mockGetMvsApi;
     });
 
     afterEach(() => {
+        (ZoweExplorerApiRegister as any).getMvsApi = originalGetMvsApi;
         jest.restoreAllMocks();
     });
 
@@ -1548,7 +1575,10 @@ describe("SharedUtils helpers", () => {
 
         const same = await SharedUtils.isSamePhysicalDataset(srcProfile, dstProfile, dsn);
         expect(same).toBe(true);
-        expect(mockGetMvsApi).toHaveBeenCalledTimes(2);
+
+        // assert dataSet was called twice
+        expect((ZoweExplorerApiRegister.getMvsApi(srcProfile) as any).dataSet).toHaveBeenCalled();
+        expect((ZoweExplorerApiRegister.getMvsApi(dstProfile) as any).dataSet).toHaveBeenCalled();
     });
 
     test("isSamePhysicalDataset returns false when dst dataset missing", async () => {

packages/zowe-explorer/__tests__/__unit__/trees/uss/USSTree.unit.test.ts

@@ -248,6 +248,19 @@ function createGlobalMocks() {
     return globalMocks;
 }
 
+function makeDataTransferWithPayload(payload: any) {
+    try {
+        const dt = new vscode.DataTransfer();
+        jest.spyOn(dt, "get").mockReturnValueOnce(payload);
+        return dt;
+    } catch {
+        // Fallback for environments where vscode.DataTransfer cannot be constructed
+        return {
+            get: jest.fn().mockReturnValueOnce(payload),
+        } as any;
+    }
+}
+
 describe("USSTree Unit Tests - Function initializeFavorites", () => {
     function createBlockMocks() {
         const session = createISession();
@@ -2283,16 +2296,17 @@ describe("USSTree.handleDrop - blocking behavior", () => {
             [srcNode.resourceUri!.path]: srcNode,
         });
 
-        // prep DataTransfer mock
-        const dataTransfer = new vscode.DataTransfer();
-        jest.spyOn(dataTransfer, "get").mockReturnValueOnce({
-            value: [
-                {
-                    label: srcNode.label as string,
-                    uri: srcNode.resourceUri,
-                },
-            ],
-        } as any);
+        // Use a plain object with a get() mock instead of new vscode.DataTransfer()
+        const dataTransfer = {
+            get: jest.fn().mockReturnValueOnce({
+                value: [
+                    {
+                        label: srcNode.label as string,
+                        uri: srcNode.resourceUri,
+                    },
+                ],
+            })
+        } as any;
 
         // mock SharedUtils.same-path detection to return true
         (SharedUtils as any).isLikelySameUssObjectByUris = jest.fn().mockResolvedValue(true);
@@ -2361,15 +2375,17 @@ describe("USSTree.handleDrop - blocking behavior", () => {
             [srcFolder.resourceUri!.path]: srcFolder,
         });
 
-        const dataTransfer = new vscode.DataTransfer();
-        jest.spyOn(dataTransfer, "get").mockReturnValueOnce({
-            value: [
-                {
-                    label: srcFolder.label as string,
-                    uri: srcFolder.resourceUri,
-                },
-            ],
-        } as any);
+        // replace DataTransfer creation with plain object
+        const dataTransfer = {
+            get: jest.fn().mockReturnValueOnce({
+                value: [
+                    {
+                        label: srcFolder.label as string,
+                        uri: srcFolder.resourceUri,
+                    },
+                ],
+            })
+        } as any;
 
         (SharedUtils as any).hasNameCollision = jest.fn().mockReturnValue(true);
         (SharedUtils as any).ERROR_SAME_OBJECT_DROP =