Edit History Webview (V3): Items are not being added to file history

[adam-wolfe]

Describe the bug

In Zowe Explorer V3 (3.0.3 and 3.1.0), files, data sets, and jobs are not being added to the file history in the Edit History Webview.

This functionality seems to work as expected in Zowe Explorer 2.18.0.

To Reproduce

1. Open any USS file, data set (or member), or spool file.
2. Open the Edit History Webview and check File History.
3. Note that the file history does not contain the file/ds/spool that you recently opened.

Expected behavior

After opening a file, the file should be listed in the file history.

Screenshots

Desktop (please complete the following information):

• OS: Win 10
• Zowe Explorer Version: 3.0.3, 3.1.0
• (Optional) Zowe CLI Version:
• (Optional) Are you using Secure Credential Store?

Additional context

[github-actions]

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

[JWaters02]

Firstly, it seems like addFileHistory is not implemented yet for Jobs:

zowe-explorer-vscode/packages/zowe-explorer/src/trees/job/JobTree.ts

Line 896 in eeeaf84

throw new Error("Method not implemented.");

I did a little debugging and noticed that when you open a dataset, addFileHistory, and above that, openDs, are never called unless you specifically only open the dataset with encoding (or from the recent files view for USS datasets as far as I have tested).

What it seems like, is that when the file is opened in the editor (by calling its URI), there is simply nothing that tells zowe explorer that the file has been opened, so subsequently it does not do any logic for actually adding the file to the history.

However, I looked at the code in v2.18.0 and found that the same thing is still happening logic-wise, but you are saying that it seems to work fine on v2... so perhaps I am missing something. I tried to checkout the v2.18.0 tag but upon building (after running pnpm install again) got many errors so just didn't bother. I could try reducing my zowe version on my work laptop to v2 and check the tracing to see if addHistory/openDs is ever called, but looking at the code, I don't see how it can be.

I do have a sneaking suspicion that it worked in v2 but not in v3 because of some shenanigans with switching from temporary filesystem to virtual filesystem, where it picked up the file history from looking at file on disk - I recall seeing something like that in the code but can't find exactly what it was.

[JillieBeanSim]

@adam-wolfe & @JWaters02 Should this issue be closed with the bug fix PR or is there more to be done for this?

[JWaters02]

@adam-wolfe & @JWaters02 Should this issue be closed with the bug fix PR or is there more to be done for this?

No, this bug is seperate to the fixes I made in #3441

That PR fixes some issues related to refreshing within the edit history view itself, while this bug is to do with it not actually adding any new items into the history in the first place (a much more major issues in my opinion).