Skip to content

Clarify output for certain config combinations w/ zwe init and zwe install #4549

@MarkAckert

Description

@MarkAckert

When we dual-path'd many of the zwe commands, we created logic that checks for configmgr/jcl enablement, and depending on their values will branch off into the TS/JCL version or stay put in the old shell scripts. This works well, but there's a few config combinations that can yield potentially unexpected outcomes.

zwe install and configmgr detection

Given in zowe.yaml:

  • zowe.setup.jcl.enable is true
  • zowe.useConfigmgr is false.
    • This setting should basically be impossible to see in new Zowe installs, but may exist in upgrades from old zowe.yaml files. So, the priority of this issue is low.

Running zwe install --dry-run --dataset-prefix TEST.DATASET.PFX --jcl -c zowe.test.yaml will successfully run with an RC=0 following the shell script path. Since useConfigmgr is set to false, the --jcl is ignored on the command line and the shell script is run. Maybe a little confusing but no problem.

Running zwe install --dry-run --dataset-prefix TEST.DATASET.PFX --jcl -c "FILE(zowe.test.yaml)" will error out with an RC=102 (incompatible flags/modes --dataset-prefix and --jcl). This is because the syntax FILE() or PARMLIB() is telling us configmgr must be enabled, and it ignores the value of zowe.useConfigmgr set in the zowe.yaml file, dropping us into JCL path.

Both of these behaviors are technically correct, but could benefit from some clarifying warnings or minor changes to how configmgr is detected. The FILE/PARMLIB syntax impacts all zwe commands, while the RC=102 is unique to zwe install.

Actions:

  • If FILE() or PARMLIB() syntax is used, and zowe.useConfigmgr is false, should we just throw an error?
  • Should we leave the first case above (RC=0) intact, or add a warning message?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions