Skip to content

Only pulls first page #6

Description

@christian-chapman

I've discovered an issue where it only pulls the first page. I took a look, and it seems like it's because the condition for "other pages" looks for images that contain exactly "s3.ultimate-guitar.com/musescore.scoredata/g/". For me, I was seeing URLs that come back like "https://s3.eu-central-1.wasabisys.com/musescore.scoredata/g/".

I tried creating a branch to make a pull request and update this to a simple regex match which could handle the original plus any variations:

images.forEach((image) => {
        if (image.src.match(/s3\..+?\.com\/musescore\.scoredata\/g/))
          matches.push(image.src);
      });

but I can't push my branch for some reason to create the PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions