2.15.1-beta-2

Author: zsviczian

manifest-beta.json

@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-excalidraw-plugin",
 	"name": "Excalidraw",
-  "version": "2.15.beta-1",
+  "version": "2.15.1-beta-2",
   "minAppVersion": "1.5.7",
 	"description": "An Obsidian plugin to edit and view Excalidraw drawings",
 	"author": "Zsolt Viczian",

src/core/managers/CommandManager.ts

@@ -781,20 +781,19 @@ export class CommandManager {
       checkCallback: (checking:boolean) => this.plugin.forceSaveActiveView(checking),
     })
 
+    //removing raw mode. Not required. I never use it. Raw mode can still be enabled
+    //via document properties. Only showing command palette action if raw mode is enabled
     this.addCommand({
       id: "toggle-lock",
       name: t("TOGGLE_LOCK"),
       checkCallback: (checking: boolean) => {
+        const view = this.app.workspace.getActiveViewOfType(ExcalidrawView);
         if (checking) {
-          if (
-            Boolean(this.app.workspace.getActiveViewOfType(ExcalidrawView))
-          ) {
-            return !(this.app.workspace.getActiveViewOfType(ExcalidrawView))
-              .compatibilityMode;
+          if (view) {
+            return !view.compatibilityMode && view.textMode === TextMode.raw;
           }
           return false;
         }
-        const view = this.app.workspace.getActiveViewOfType(ExcalidrawView);
         if (view && !view.compatibilityMode) {
           view.changeTextMode(
             view.textMode === TextMode.parsed ? TextMode.raw : TextMode.parsed,
@@ -1707,15 +1706,19 @@ export class CommandManager {
         const PDFLink = this.plugin.getLastActivePDFPageLink(view.file);
         if(!PDFLink) return false;
         if(checking) return true;
-        const ea = getEA(view);
-        insertImageToView(
-          ea,
-          view.currentPosition,
-          PDFLink,
-          undefined,
-          undefined,
-          true,
-        );
+        (async()=>{
+          const ea = getEA(view) as ExcalidrawAutomate;
+          const id = await insertImageToView(
+            ea,
+            view.currentPosition,
+            PDFLink,
+            undefined,
+            undefined,
+            true,
+          );
+          ea.selectElementsInView([id]);
+          ea.destroy()
+        })();
       },
     });
 

src/shared/ExcalidrawAutomate.ts

@@ -89,6 +89,7 @@ import { FrameRenderingOptions } from "src/types/utilTypes";
 import { CaptureUpdateAction } from "src/constants/constants";
 import { AutoexportConfig } from "src/types/excalidrawViewTypes";
 import { FloatingModal } from "./Dialogs/FloatingModal";
+import { patchMobileView } from "src/utils/customEmbeddableUtils";
 
 extendPlugins([
   HarmonyPlugin,
@@ -2753,15 +2754,19 @@ export class ExcalidrawAutomate {
       errorMessage("targetView not set", "addElementsToView()");
       return false;
     }
-    const elements = this.getElements();    
-    return await this.targetView.addElements({
+    const elements = this.getElements();
+    if(elements.some(el=>el.type === "embeddable")) {
+      patchMobileView(this.targetView);
+    }
+    const result = await this.targetView.addElements({
       newElements: elements,
       repositionToCursor,
       save,
       images: this.imagesDict,
       newElementsOnTop,
       shouldRestoreElements,
     });
+    return result;
   };
 
   /**

src/utils/customEmbeddableUtils.ts

@@ -13,6 +13,7 @@ export const leafMap = new Map<string, WorkspaceLeaf>();
 
 //This is definitely not the right solution, feels like sticking plaster
 //patch disappearing content on mobile
+//based on obsidian app.js, obsidian is looking for activeEditor, but active editor is in a leaf that is disconnected from root
 export const patchMobileView = (view: ExcalidrawView) => {
   if(DEVICE.isDesktop) return;
   console.log("patching mobile view");
@@ -21,6 +22,14 @@ export const patchMobileView = (view: ExcalidrawView) => {
     if(!parent.hasClass("mod-visible")) {
       parent.addClass("mod-visible");
     }
+    //create observer here
+    const observer = new MutationObserver(() => {
+      if(!parent.hasClass("mod-visible")) {
+        parent.addClass("mod-visible");
+      }
+    });
+    observer.observe(parent, { attributes: true, attributeFilter: ["class"] });
+    window.setTimeout(() => observer.disconnect(), 500);
   }
 }
 

src/utils/excalidrawViewUtils.ts

@@ -36,7 +36,7 @@ export async function insertImageToView(
     file,
     scale,
   );
-  if(shouldInsertToView) {await ea.addElementsToView(repositionToCursor, true, true);}
+  if(shouldInsertToView) {await ea.addElementsToView(repositionToCursor, true, true, true);}
   return id;
 }
 

src/view/ExcalidrawView.ts

@@ -1650,11 +1650,11 @@ export default class ExcalidrawView extends TextFileView implements HoverParent{
       t("RAW"),
       () => this.changeTextMode(TextMode.parsed),
     );
-    this.actionButtons['isParsed'] = this.addAction(
+   /*this.actionButtons['isParsed'] = this.addAction(
       TEXT_DISPLAY_PARSED_ICON_NAME,
       t("PARSED"),
       () => this.changeTextMode(TextMode.raw),
-    );
+    );*/
 
     this.actionButtons['link'] = this.addAction("link", t("OPEN_LINK"), (ev) =>
       this.handleLinkClick(ev),
@@ -1846,7 +1846,7 @@ export default class ExcalidrawView extends TextFileView implements HoverParent{
     this.textMode = textMode;
     if (textMode === TextMode.parsed) {
       this.actionButtons['isRaw'].hide();
-      this.actionButtons['isParsed'].show();
+      this.actionButtons['isParsed'].hide();
     } else {
       this.actionButtons['isRaw'].show();
       this.actionButtons['isParsed'].hide();

src/view/components/CustomEmbeddable.tsx

@@ -92,6 +92,25 @@ function setupPdfViewEnhancements(
     pdfObserverDisabledRef.current = true;
     setPDFViewTheme(view, pdfView);
     requestAnimationFrame(() => { pdfObserverDisabledRef.current = false; });
+    
+    // Observe inline height changes on the PDF root container and reset them
+    // this could be an obsidian bug, should be revisted later 2025-08-23
+    const containerEl = pdfView.containerEl as HTMLElement | null;
+    let prevHeight = containerEl?.style?.height || "";
+    let heightObserver: MutationObserver | null = null;
+    if (containerEl) {
+      heightObserver = new MutationObserver(() => {
+        const h = containerEl.style.height || "";
+        if (h !== prevHeight) {
+          prevHeight = h;
+          if (h) {
+            containerEl.style.height = "";
+            prevHeight = "";
+          }
+        }
+      });
+      heightObserver.observe(containerEl, { attributes: true, attributeFilter: ["style"] });
+    }
 
     // Transform-aware MMB drag-to-scroll (bypasses Chromium autoscroll)
     const scroller = pdfView.containerEl?.querySelector(".pdf-viewer-container") || null;
@@ -185,6 +204,8 @@ function setupPdfViewEnhancements(
       window.removeEventListener("pointermove", onPointerMove, { capture: true } as any);
       window.removeEventListener("pointerup", onPointerUp,   { capture: true } as any);
       window.removeEventListener("pointercancel", onPointerUp,{ capture: true } as any);
+      heightObserver?.disconnect();
+      heightObserver = null;
     };
     (pdfObserverRef as any).currentCleanup = () => { cleanupPan(); };
 
@@ -416,6 +437,8 @@ function RenderObsidianView(
       node: null,
       editNode: null,
     };
+
+    patchMobileView(view);
     //if subpath is defined, create a canvas node else create a workspace leaf
     if(subpath && view.canvasNodeFactory.isInitialized() && file.extension.toLowerCase() === "md") {
       setKeepOnTop();
@@ -446,7 +469,6 @@ function RenderObsidianView(
           containerRef.current.appendChild(rootSplit.containerEl);
           setColors(containerRef.current, element, mdProps, canvasColor, viewType);
         }
-        patchMobileView(view);
         view.updateEmbeddableLeafRef(element.id, leafRef.current);
 
         if(viewType === "pdf") {
@@ -630,9 +652,9 @@ function RenderObsidianView(
         if (!modes) {
           return;
         }
+        patchMobileView(view);
         leafRef.current.leaf.view.setMode(modes['source']);
         isEditingRef.current = true;
-        patchMobileView(view);
       } else if (leafRef.current?.node) {
         //Handle canvas node
         const newTheme = getTheme(view, themeRef.current);

src/view/components/menu/EmbeddableActionsMenu.tsx

@@ -131,30 +131,33 @@ export class EmbeddableMenu {
     this.updateElement(`#page=${page}`, element, pdfFile, false);
   }
 
-  private actionInsertPageAsImage (element: ExcalidrawEmbeddableElement) {
+  private async actionInsertPageAsImage (element: ExcalidrawEmbeddableElement) {
     if(!element) return;
     const pdfView = this.view.getEmbeddableLeafElementById(element.id)?.node?.child;
     if(!pdfView) return;
     const page = getActivePDFPageNumberFromPDFView(pdfView);
     if(!page) return;
     const pdfFile: TFile = pdfView?.file;
     if(!pdfFile) return;
-    const ea = getEA(this.view);
+    const ea = getEA(this.view) as ExcalidrawAutomate;
+    ea.selectElementsInView([]);
     const x = element.x + element.width + 20;
     const y = element.y;
     const path = this.view.app.metadataCache.fileToLinktext(
       pdfFile,
       this.view.file.path,
       false,
     )
-    insertImageToView(
+    const id = await insertImageToView(
       ea,
       {x,y},
       `${path}#page=${page}`,
       undefined,
       undefined,
       false,
     );
+    ea.selectElementsInView([id]);
+    ea.destroy();
   }
 
   private async actionMarkdownBlock (file: TFile, subpath: string, element: ExcalidrawEmbeddableElement) {

styles.css

@@ -875,4 +875,8 @@ textarea.excalidraw-wysiwyg, .excalidraw input {
 
 .excalidraw__embeddable-container .pdf-toolbar-right {
   display: none;
+}
+
+.excalidraw-scriptengine-install .modal-close-button {
+  z-index: 9999;
 }