Fixed:Broken image icon in left sidebar and typo in classname #630 #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken image icon was shown for a few seconds before realm character icon replaced it. This replaces the broken image icon by realm character in alt attribute. This fixes zulip#630.
|
I accidentally messed up the previous PR, so reopened again. Sorry for the inconvenience caused. |
|
This needs to be referenced to the appropriate issue number. I accidentally assigned myself that issue, because i did not see any open PRs for that issue. |
|
@akashnimare Can you review this PR please? :D |
|
Heads up @Nikhil-Vats, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
@Nikhil-Vats hey, can you fix the merge conflicts please and maybe upload a gif to show the fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
The initial letter of Organistaion's name is shown instead of broken image when the app starts and typing mistake in main.js file in classname is fixed.
You have tested this PR on:
Fixes Broken image icon in left sidebar #562