dialog: Add error haptic feedback to showErrorDialog.

Previously, showErrorDialog provided only visual feedback when
displaying an error. This can make error notifications easier
to miss on devices that support haptic feedback.

Call HapticFeedback.errorNotification() when showing an error
dialog so users receive platform-appropriate tactile feedback
in addition to the visual dialog.

Fixes #2338.

Author: sharayuwadghule

lib/widgets/dialog.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/cupertino.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter/services.dart';
 
 import '../generated/l10n/zulip_localizations.dart';
 import '../model/settings.dart';
@@ -165,6 +166,7 @@ DialogStatus<void> showErrorDialog({
   String? message,
   Uri? learnMoreButtonUrl,
 }) {
+  HapticFeedback.errorNotification();
   final zulipLocalizations = ZulipLocalizations.of(context);
   final future = showDialog<void>(
     context: context,

test/flutter_checks.dart

@@ -62,6 +62,11 @@ extension TextEditingValueChecks on Subject<TextEditingValue> {
   Subject<TextRange> get composing => has((x) => x.composing, 'composing');
 }
 
+extension MethodCallChecks on Subject<MethodCall> {
+  Subject<String> get method => has((c) => c.method, 'method');
+  Subject<Object?> get arguments => has((c) => c.arguments as Object?, 'arguments');
+}
+
 //|//////////////////////////////////////////////////////////////
 // From 'package:flutter/animation.dart'.
 //

test/widgets/dialog_test.dart

@@ -1,13 +1,15 @@
 import 'package:checks/checks.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter/services.dart';
 import 'package:flutter_checks/flutter_checks.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:url_launcher/url_launcher.dart';
 import 'package:zulip/model/settings.dart';
 import 'package:zulip/widgets/app.dart';
 import 'package:zulip/widgets/dialog.dart';
 
+import '../flutter_checks.dart';
 import '../model/binding.dart';
 import 'dialog_checks.dart';
 import 'test_app.dart';
@@ -38,6 +40,25 @@ void main() {
       checkErrorDialog(tester, expectedTitle: title, expectedMessage: message);
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
 
+    testWidgets('triggers error haptic feedback', (tester) async {
+      await prepare(tester);
+
+      final calls = <MethodCall>[];
+      tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
+        SystemChannels.platform,
+        (methodCall) async {
+          calls.add(methodCall);
+          return null;
+        });
+
+      showErrorDialog(context: context, title: title, message: message);
+      await tester.pump();
+
+      check(calls).single
+        ..method.equals('HapticFeedback.vibrate')
+        ..arguments.equals('HapticFeedbackType.errorNotification');
+    }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
+
     testWidgets('user closes error dialog', (tester) async {
       await prepare(tester);