Skip to content

Handle user-group renames in rendering @-mentions #1259

Open
@gnprice

Description

@gnprice

Currently we render @-mentions of user groups using the group's name as recorded in the HTML. If the mentioned group has been renamed since the message was sent (or was last edited), this will be its old name. Instead, we should show the mentioned group's current name.

To do this we'll use the mentioned group's ID, which is also encoded in the HTML of the @-mention. Then we can look that up in our user-groups data, once we have that (#662). If the group is unknown, we can fall back to the name that's in the HTML.

This behavior is specified in docs just written today: https://zulip.com/api/message-formatting#mentions (or maybe this link; added in zulip/zulip@3aa2671), but I believe it's been the web app's behavior for a long time.

Related issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    a-contentParsing and rendering Zulip HTML content, notably message contents

    Type

    No type

    Projects

    • Status

      No status

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions