@chrisbobbe I've made the changes as mentioned, Please take a look when you have time, Thank you.

See also the chat thread I started for sorting out the available APIs here:
https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/Android.20APIs.20for.20downloading.20an.20image/near/2010826

I'd like to hear there much the same information I asked for at #1144 (comment) above — that'd help us compare this API to alternatives and work out what solution we want.

@gnprice I've worked on the reviews you've given,

• Implemented the same with pigeon ( still not sure if its the right way ).
• Reduced the comments to just the needed ones.

Please take a look when you have time. Thank you

Thanks!

On a high-level scan, this structure looks good. The use of a new file pigeon/media_scanner.dart and the MediaScannerHost class look like the right structure for implementing a call to the Android side.

The main thing this will need is tests. In this version, the test case checks that a snack bar gets shown, but not any part of the actual functionality of the button. There's significant logic in that onPressed callback, and we'll want tests for that logic.

To do that, the main ingredient you'll need is to call the host scanFile method via a method you'll add to ZulipBinding, rather than calling it directly. See the advice in this section of our README:
https://github.com/zulip/zulip-flutter/?tab=readme-ov-file#writing-tests

For examples using Pigeon, see our notifications tests. For a simpler example though not using Pigeon, try looking at ZulipBinding.pickFiles, and the place where that's called, and the test in test/widgets/compose_box_test.dart that tests the place where pickFiles is called.

You might also need to add a ZulipBinding method for getExternalStorageDirectory, which should be a fairly simple binding method to add.

Modified the download implementation to use the DownloadManager API instead of the File API and MediaScannerConnection.scanFile() from the last review. Also wrote tests to verify the functionality of the download using TestZulipBinding.

@gnprice , could you please review it?

Thanks @chimnayajith for all your work on this!

I like this idea of using DownloadManager — I think that's likely to be the right strategy for us to use. The structure of this code looks broadly good, though I haven't reviewed it in detail.

This issue is for the M6 Post-launch milestone, though, and I've determined we need to start focusing more strictly on launch issues in order to get the app launched to our users on schedule. And there's still significant work ahead to get this completed, partly because there's always an extra level of care and validation required when dealing with platform APIs.

Given that, let's put this PR on hold for now. We can plan for you to pick this issue up from here when we're ready to resume work on post-launch issues.