Support saved snippets #1391
Draft
Support saved snippets #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
force-pushed
the
pr-saved
branch
2 times, most recently
from
5c40618 to
66b1605
Compare
The theme already applies to all of our bottom sheets, and all of them uses Clip.antiAlias already. Signed-off-by: Zixuan James Li <[email protected]>
Not all buttons are about uploading files, while most of the buttons on the compose box share the same design. Extract that part for later use. Signed-off-by: Zixuan James Li <[email protected]>
Both widgets are agnostic to any specific compose controller, so that we can reuse the styling elsewhere. Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
This makes inline implementations for these build… methods possible, without defining a separate StatelessWidget class. Signed-off-by: Zixuan James Li <[email protected]>
This will later become useful for tetsing saved snippets, a feature only available after server 10. Signed-off-by: Zixuan James Li <[email protected]>
The icons taken are from the Figma design: plus: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4912-31325&m=dev message-square-text: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=7965-53132&m=dev Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
This will allow controller implementations that do not support validation errors akin to "*TooLong" to set this to null.
TODO: look for a better way to arrange the new compose box We sort the saved snippets by title to be consistent with the web implementation. A subtle nuance of having a compose box in a modal bottom sheet is that the message list page behind will shift when the keyboard is expanded, even though its compose box is not visible anyway. An UX improvement would be preserving the inputs on the saved snippet compose box after the user has navigated away. Signed-off-by: Zixuan James Li <[email protected]>
This reverts commit d10140a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #863