Skip to content

Commit 801ce9e

Browse files
committed
refactor: run: Use distinct variable names to satisfy mypy.
1 parent 86b308c commit 801ce9e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

zulipterminal/cli/run.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -513,11 +513,11 @@ def main(options: Optional[List[str]] = None) -> None:
513513
)
514514

515515
# Validate remaining settings
516-
for setting, valid_values in valid_remaining_settings.items():
517-
if zterm[setting].value not in valid_values:
516+
for setting, valid_remaining_values in valid_remaining_settings.items():
517+
if zterm[setting].value not in valid_remaining_values:
518518
helper_text = (
519519
["Valid values are:"]
520-
+ [f" {option}" for option in valid_values]
520+
+ [f" {option}" for option in valid_remaining_values]
521521
+ [f"Specify the {setting} option in zuliprc file."]
522522
)
523523
exit_with_error(
@@ -563,8 +563,8 @@ def print_setting(setting: str, data: SettingData, suffix: str = "") -> None:
563563

564564
# Translate valid strings for boolean values into True/False
565565
boolean_settings: Dict[str, bool] = dict()
566-
for setting, valid_values in VALID_BOOLEAN_SETTINGS.items():
567-
boolean_settings[setting] = zterm[setting].value == valid_values[0]
566+
for setting, valid_boolean_values in VALID_BOOLEAN_SETTINGS.items():
567+
boolean_settings[setting] = zterm[setting].value == valid_boolean_values[0]
568568

569569
Controller(
570570
config_file=zuliprc_path,

0 commit comments

Comments
 (0)