Skip to content

Event traceback from peer_remove event #1220

Open
@neiljp

Description

@neiljp

I've only seen this once, so this is likely an uncommon situation. This caused the popup which occurs when an event handler function doesn't handle all exceptions, from an error on line 1241 of models.py.

We likely want to check that a user removed from our known users in a stream is present before removing them, or else handle the exception instead - basically limit the exception from leaking out and giving the popup which occurs in these situations.

This is very likely a small change, but shouldn't really occur unless we miss a peer_add event for some reason, or else there is some timing issue, though it is possible there is something else going on. For that reason we likely want a comment in the code. It may also be worth exploring if the web app or mobile modifies this data in another situation which we may be missing.

Due to the challenge of debugging this behavior, we definitely want to add/extend tests for this case.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: event handlingHow events from the server are responded tobugSomething isn't workinghelp wantedThis issue should be clear enough to work on

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions