Regression updating from 1.9.9 -> 1.9.10?

[reynaldichernando]

Here's the difference, seems like it's triggering the default image thing, when it should succeed in 1.9.9

1.9.9 (click to open the spoiler)

1.9.10 (click to open the spoiler)

Edit: used spoiler

[reynaldichernando]

1.9.11 also has the same issue btw

[tinchox5]

1.9.11 has the same issue?

[reynaldichernando]

here's 1.9.11, also sorry for the long screenshot lol

1.9.11 (click to open the spoiler)

[tinchox5]

No problem! there is an undocumented option: placeholders, please try set to false.

[reynaldichernando]

1.9.11 + placeholders

The placeholder is gone, but so is the image 😢

FYI, the images allow CORS, and even if they don't, I have the proxy setup with Corsfix

const generateImage = async (element: HTMLElement) => {
  const blob = await snapdom.toBlob(element, {
    useProxy: "https://proxy.corsfix.com/?url=",
    backgroundColor: "#fff",
    placeholders: false,
    fast: true,
    quality: 0.7,
    type: imageFormat,
  });

  return URL.createObjectURL(blob);
};

[reynaldichernando]

btw slightly unrelated, if Snapdom wanted a cors proxy sponsor for any reason, feel free to hit me up.
For example to show it can work with cross origin assets via the useProxy config

[tinchox5]

Yes it would be great!

[reynaldichernando]

sent you an email!

[tinchox5]

Or... https://github.com/zumerlab/snapdom?tab=readme-ov-file#fallback-image-on-img-load-failure

[tinchox5]

Ok thank you! I'll fix it. Proxy maybe was not taken into consideration now. Sorry for that

[reynaldichernando]

No worries, it's awesome how responsive you are.
I was just testing to see the performance boost from the upgrade, but accidentally found this issue. 😅

[tinchox5]

@reynaldichernando pls try if this prerelease fix the regression + @zumer/[email protected]

[reynaldichernando]

So this new version did fix the issue, but I had to disable the placeholders settings first.

I'm not sure if this is the intended behaviour (?), since if i don't change the placeholders, it still shows the gray square with "image" text

[reynaldichernando]

Let me know if there is any additional info I can provide to help the troubleshooting.

[tinchox5]

Thank you for the feedback! Yes thats the idea. If not placeholders you should not see fallback for images and iframes.

[reynaldichernando]

thanks, if the images were fetched successfully (either directy or via proxy), it will show the correct images?

just to clarify, so the order for the processing becomes:

1. fetch and show image directly
2. fetch and show image via proxy
3. show placeholder

if disable placeholder, it will be:

1. fetch and show image directly
2. fetch and show image via proxy
3. show nothing

[tinchox5]

Thats the idea. Also there is a new option (name may change): defaultImageUrl that allows provide a fallback image url