fix: use vim.pack.get() as source of truth for ZClean

ZClean was not detecting orphan plugins (removed from spec but still
installed) because it only checked plugins in state.registered_plugins.

Now ZClean calls vim.pack.get() directly to get all installed plugins
and compares against spec_registry to find orphans.

Author: zuqini

lua/zpack/commands.lua

@@ -70,10 +70,12 @@ end
 
 M.clean_unused = function()
   local to_delete = {}
+  local installed = vim.pack.get() or {}
 
-  for _, spec in ipairs(state.registered_plugins) do
-    if not state.spec_registry[spec.src] and not string.find(spec.src, 'zpack') then
-      table.insert(to_delete, spec.name)
+  for _, pack in ipairs(installed) do
+    local src = pack.spec.src
+    if not state.spec_registry[src] and not string.find(src, 'zpack') then
+      table.insert(to_delete, pack.spec.name)
     end
   end
 

tests/helpers.lua

@@ -151,17 +151,27 @@ function M.setup_test_env()
   _G.test_state.registered_pack_specs = {}
   vim.pack.get = function(names)
     local results = {}
-    for _, name in ipairs(names) do
-      local pack_spec = _G.test_state.registered_pack_specs[name]
-      if pack_spec then
+    if names == nil or #names == 0 then
+      for name, pack_spec in pairs(_G.test_state.registered_pack_specs) do
         table.insert(results, {
           spec = pack_spec,
           path = vim.fn.stdpath('data') .. '/site/pack/zpack/opt/' .. name,
           name = name,
         })
       end
+    else
+      for _, name in ipairs(names) do
+        local pack_spec = _G.test_state.registered_pack_specs[name]
+        if pack_spec then
+          table.insert(results, {
+            spec = pack_spec,
+            path = vim.fn.stdpath('data') .. '/site/pack/zpack/opt/' .. name,
+            name = name,
+          })
+        end
+      end
     end
-    return #results > 0 and results or nil
+    return #results > 0 and results or {}
   end
 
   _G.test_state.original_vim_pack_del = vim.pack.del

tests/run_all.lua

@@ -25,6 +25,7 @@ local test_modules = {
   'dependencies_test',
   'module_loader_test',
   'zdelete_test',
+  'zclean_test',
 }
 
 print("\n" .. string.rep("=", 60))

tests/zclean_test.lua

@@ -0,0 +1,98 @@
+local helpers = require('helpers')
+
+return function()
+  helpers.describe("ZClean Command", function()
+    helpers.test("ZClean detects orphan plugins not in spec", function()
+      helpers.setup_test_env()
+
+      require('zpack').setup({
+        spec = {
+          { 'test/plugin-a' },
+          { 'test/plugin-b' },
+        },
+        defaults = { confirm = false },
+      })
+
+      helpers.flush_pending()
+
+      _G.test_state.registered_pack_specs['orphan-plugin'] = {
+        src = 'test/orphan-plugin',
+        name = 'orphan-plugin',
+      }
+
+      vim.cmd('ZClean')
+      helpers.flush_pending()
+
+      helpers.assert_equal(#_G.test_state.vim_pack_del_calls, 1, "vim.pack.del should be called")
+      local call = _G.test_state.vim_pack_del_calls[1]
+      helpers.assert_table_contains(call.names, 'orphan-plugin', "orphan plugin should be in delete list")
+      helpers.assert_equal(#call.names, 1, "only orphan plugin should be deleted")
+
+      helpers.cleanup_test_env()
+      helpers.delete_zpack_commands()
+    end)
+
+    helpers.test("ZClean does not delete plugins in spec", function()
+      helpers.setup_test_env()
+
+      require('zpack').setup({
+        spec = {
+          { 'test/plugin-a' },
+          { 'test/plugin-b' },
+        },
+        defaults = { confirm = false },
+      })
+
+      helpers.flush_pending()
+
+      vim.cmd('ZClean')
+      helpers.flush_pending()
+
+      helpers.assert_equal(#_G.test_state.vim_pack_del_calls, 0, "vim.pack.del should not be called")
+
+      local found_info = false
+      for _, notif in ipairs(_G.test_state.notifications) do
+        if notif.msg:find('No unused plugins') and notif.level == vim.log.levels.INFO then
+          found_info = true
+          break
+        end
+      end
+      helpers.assert_true(found_info, "Should show info that no unused plugins exist")
+
+      helpers.cleanup_test_env()
+      helpers.delete_zpack_commands()
+    end)
+
+    helpers.test("ZClean detects multiple orphan plugins", function()
+      helpers.setup_test_env()
+
+      require('zpack').setup({
+        spec = {
+          { 'test/plugin-a' },
+        },
+        defaults = { confirm = false },
+      })
+
+      helpers.flush_pending()
+
+      _G.test_state.registered_pack_specs['orphan-1'] = {
+        src = 'test/orphan-1',
+        name = 'orphan-1',
+      }
+      _G.test_state.registered_pack_specs['orphan-2'] = {
+        src = 'test/orphan-2',
+        name = 'orphan-2',
+      }
+
+      vim.cmd('ZClean')
+      helpers.flush_pending()
+
+      helpers.assert_equal(#_G.test_state.vim_pack_del_calls, 1, "vim.pack.del should be called once")
+      local call = _G.test_state.vim_pack_del_calls[1]
+      helpers.assert_equal(#call.names, 2, "both orphan plugins should be deleted")
+
+      helpers.cleanup_test_env()
+      helpers.delete_zpack_commands()
+    end)
+  end)
+end