Skip to content

Commit b213631

Browse files
del ci v17/19,add 20.x.modify issue 1328 test case
1 parent d2f8b02 commit b213631

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

.github/workflows/tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
node-version: [10.x, 12.x, 14.x, 16.x, 17.x, 18.x, 19.x]
16+
node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x]
1717
os: [ubuntu-latest, macOS-latest, windows-latest]
1818
runs-on: ${{ matrix.os }}
1919

8.1 KB
Binary file not shown.

spec/integration/issues/issue-1328-xlsx-worksheet-reader-date.spec.js

+10-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ describe('github issues: Date field with cache style', () => {
77
() =>
88
new Promise((resolve, reject) => {
99
const workbookReader = new ExcelJS.stream.xlsx.WorkbookReader(
10-
fs.createReadStream('./spec/integration/data/dateIssue.xlsx'),
10+
// fs.createReadStream('./spec/integration/data/dateIssue.xlsx'), //old
11+
fs.createReadStream('./spec/integration/data/dateIssueNew.xlsx'),
1112
{
1213
worksheets: 'emit',
1314
styles: 'cache',
@@ -25,8 +26,15 @@ describe('github issues: Date field with cache style', () => {
2526
})
2627
);
2728
it('issue 1328 - should emit row with Date Object', () => {
29+
// old
30+
// expect(rows).that.deep.equals([
31+
// 'Date',
32+
// new Date('2020-11-20T00:00:00.000Z'),
33+
// ]);
34+
35+
// new
2836
expect(rows).that.deep.equals([
29-
'Date',
37+
// 'Date',
3038
new Date('2020-11-20T00:00:00.000Z'),
3139
]);
3240
});

0 commit comments

Comments
 (0)