Skip to content

Commit ac655f9

Browse files
committed
improvement: Correct disk healthy check min number config key
1 parent 48a3c65 commit ac655f9

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/config.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ pub struct KerberosSecurityConfig {
104104
pub struct LocalfileStoreConfig {
105105
pub data_paths: Vec<String>,
106106
#[serde(default = "as_default_healthy_check_min_disks")]
107-
pub healthy_check_min_disks: i32,
107+
pub min_number_of_available_disks: i32,
108108
#[serde(default = "as_default_disk_high_watermark")]
109109
pub disk_high_watermark: f32,
110110
#[serde(default = "as_default_disk_low_watermark")]
@@ -144,7 +144,7 @@ impl LocalfileStoreConfig {
144144
pub fn new(data_paths: Vec<String>) -> Self {
145145
LocalfileStoreConfig {
146146
data_paths,
147-
healthy_check_min_disks: as_default_healthy_check_min_disks(),
147+
min_number_of_available_disks: as_default_healthy_check_min_disks(),
148148
disk_high_watermark: as_default_disk_high_watermark(),
149149
disk_low_watermark: as_default_disk_low_watermark(),
150150
disk_max_concurrency: as_default_disk_max_concurrency(),

src/store/localfile.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ impl From<LocalDiskDelegator> for LockedObj {
7272

7373
pub struct LocalFileStore {
7474
local_disks: Vec<LocalDiskDelegator>,
75-
healthy_check_min_disks: i32,
75+
min_number_of_available_disks: i32,
7676
runtime_manager: RuntimeManager,
7777
partition_locks: DashMap<String, Arc<RwLock<LockedObj>>>,
7878
}
@@ -93,7 +93,7 @@ impl LocalFileStore {
9393
}
9494
LocalFileStore {
9595
local_disks: local_disk_instances,
96-
healthy_check_min_disks: 1,
96+
min_number_of_available_disks: 1,
9797
runtime_manager,
9898
partition_locks: Default::default(),
9999
}
@@ -118,7 +118,7 @@ impl LocalFileStore {
118118
}
119119
LocalFileStore {
120120
local_disks: local_disk_instances,
121-
healthy_check_min_disks: localfile_config.healthy_check_min_disks,
121+
min_number_of_available_disks: localfile_config.min_number_of_available_disks,
122122
runtime_manager,
123123
partition_locks: Default::default(),
124124
}
@@ -171,9 +171,9 @@ impl LocalFileStore {
171171

172172
debug!(
173173
"disk: available={}, healthy_check_min={}",
174-
available, self.healthy_check_min_disks
174+
available, self.min_number_of_available_disks
175175
);
176-
Ok(available > self.healthy_check_min_disks)
176+
Ok(available >= self.min_number_of_available_disks)
177177
}
178178

179179
fn select_disk(&self, uid: &PartitionedUId) -> Result<LocalDiskDelegator, WorkerError> {

0 commit comments

Comments
 (0)