Smoke sensors show multiple "idle" sensors without further context

[AlCalzone]

Diagnostics:
zwave_js-01KC6RYJZ4C45X3M9A19R71NZ0-Node 6-abed019bc366687fad59d05289caf7c9.json

These are the following sensors:

      {
        "domain": "binary_sensor",
        "entity_id": "binary_sensor.rauchmelder_idle",
        "original_name": "idle",
        "original_device_class": null,
        "disabled": false,
        "disabled_by": null,
        "hidden_by": null,
        "original_icon": null,
        "entity_category": "diagnostic",
        "supported_features": 0,
        "unit_of_measurement": null,
        "value_id": "6-113-0-Smoke Alarm-Sensor status",
        "primary_value": {
          "command_class": 113,
          "command_class_name": "Notification",
          "endpoint": 0,
          "property": "Smoke Alarm",
          "property_name": "Smoke Alarm",
          "property_key": "Sensor status",
          "property_key_name": "Sensor status",
          "state_key": 0
        }
      },
      {
        "domain": "binary_sensor",
        "entity_id": "binary_sensor.rauchmelder_idle_2",
        "original_name": "idle",
        "original_device_class": null,
        "disabled": false,
        "disabled_by": null,
        "hidden_by": null,
        "original_icon": null,
        "entity_category": "diagnostic",
        "supported_features": 0,
        "unit_of_measurement": null,
        "value_id": "6-113-0-Smoke Alarm-Alarm status",
        "primary_value": {
          "command_class": 113,
          "command_class_name": "Notification",
          "endpoint": 0,
          "property": "Smoke Alarm",
          "property_name": "Smoke Alarm",
          "property_key": "Alarm status",
          "property_key_name": "Alarm status",
          "state_key": 0
        }
      },
      {
        "domain": "binary_sensor",
        "entity_id": "binary_sensor.rauchmelder_idle_3",
        "original_name": "idle",
        "original_device_class": null,
        "disabled": false,
        "disabled_by": null,
        "hidden_by": null,
        "original_icon": null,
        "entity_category": "diagnostic",
        "supported_features": 0,
        "unit_of_measurement": null,
        "value_id": "6-113-0-Smoke Alarm-Dust in device status",
        "primary_value": {
          "command_class": 113,
          "command_class_name": "Notification",
          "endpoint": 0,
          "property": "Smoke Alarm",
          "property_name": "Smoke Alarm",
          "property_key": "Dust in device status",
          "property_key_name": "Dust in device status",
          "state_key": 0
        }
      },

[MartinHjelmare]

I think we need to extend this set with the idle state. I missed this when doing the refactor of the smoke alarms to the new discovery schema.

https://github.com/home-assistant/core/blob/1da31c0530d1a5f8a87864b24b2b4b2d86d85b26/homeassistant/components/zwave_js/binary_sensor.py#L656-L663

[MartinHjelmare]

Probably also add the idle value to this enum:

https://github.com/home-assistant-libs/zwave-js-server-python/blob/419d9248a2673939cf2baa2966019ce72e76fee6/zwave_js_server/const/command_class/notification.py#L54

And fix the parent to that enum here:

https://github.com/home-assistant-libs/zwave-js-server-python/blob/419d9248a2673939cf2baa2966019ce72e76fee6/zwave_js_server/const/command_class/notification.py#L592

[MartinHjelmare]

Many of the notification event values seem to be inheriting the wrong base class in the client library.

[MartinHjelmare]

PR to fix the issue in core:
home-assistant/core#160604

[MartinHjelmare]

I added idle to the notification event (state) enums here:
home-assistant-libs/zwave-js-server-python#1370

My other comments about wrong parent class were incorrect.

I think we can close here now. We can improve the integration in core and use the new idle enum value, but we don't need to track that here.