Skip to content

Commit a6370ae

Browse files
raman325claude
andcommitted
fix: address PR review feedback
- buffer2hex: normalize JSON-parsed buffer input (number[] or {type,data}) - getSupportedRFRegions: use readonly in outgoing type, remove unnecessary spread - getCCs: simplify with Object.fromEntries Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 2f8593d commit a6370ae

5 files changed

Lines changed: 8 additions & 11 deletions

File tree

src/lib/controller/message_handler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ export class ControllerMessageHandler implements MessageHandler {
735735
const regions = this.driver.controller.getSupportedRFRegions(
736736
message.filterSubsets,
737737
);
738-
return { regions: regions ? [...regions] : undefined };
738+
return { regions: regions ?? undefined };
739739
}
740740
default: {
741741
throw new UnknownCommandError(command);

src/lib/controller/outgoing_message.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,6 @@ export interface ControllerResultTypes {
196196
};
197197
// RF region info
198198
[ControllerCommand.getSupportedRFRegions]: {
199-
regions: RFRegion[] | undefined;
199+
regions: readonly RFRegion[] | undefined;
200200
};
201201
}

src/lib/endpoint/message_handler.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,13 +112,8 @@ export class EndpointMessageHandler implements MessageHandler {
112112
return getRawConfigParameterValue(message, endpoint);
113113
}
114114
case EndpointCommand.getCCs: {
115-
const result: EndpointResultTypes[EndpointCommand.getCCs] = {
116-
commandClasses: {},
117-
};
118-
for (const [ccId, info] of endpoint.getCCs()) {
119-
result.commandClasses[ccId] = info;
120-
}
121-
return result;
115+
const commandClasses = Object.fromEntries(endpoint.getCCs());
116+
return { commandClasses };
122117
}
123118
case EndpointCommand.maySupportBasicCC: {
124119
const maySupport = endpoint.maySupportBasicCC();

src/lib/utils/incoming_message.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export interface IncomingCommandUtilsFormatId extends IncomingCommandUtilsBase {
2828

2929
export interface IncomingCommandUtilsBuffer2hex extends IncomingCommandUtilsBase {
3030
command: UtilsCommand.buffer2hex;
31-
buffer: Buffer<ArrayBuffer>; // Parsed buffers own their data
31+
buffer: number[] | { type: "Buffer"; data: number[] };
3232
uppercase: boolean;
3333
}
3434

src/lib/utils/message_handler.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ export class UtilsMessageHandler implements MessageHandler {
3636
return { id };
3737
}
3838
case UtilsCommand.buffer2hex: {
39-
const hex = buffer2hex(message.buffer, message.uppercase);
39+
const raw = message.buffer;
40+
const bytes = Array.isArray(raw) ? raw : raw.data;
41+
const hex = buffer2hex(Uint8Array.from(bytes), message.uppercase);
4042
return { hex };
4143
}
4244
case UtilsCommand.getEnumMemberName: {

0 commit comments

Comments
 (0)