ft(jwt):configure json-web-tokens [Finishes #171110014] #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MillieNakiganda
force-pushed
the
ft-json-web-tokens-171110014
branch
from
c1cfeda to
9950f15
Compare
MillieNakiganda
force-pushed
the
ft-json-web-tokens-171110014
branch
from
9950f15 to
6ad9f71
Compare
nkalyesubula
requested changes
Jul 11, 2020
Member
nkalyesubula
left a comment
nkalyesubula
left a comment
There was a problem hiding this comment.
Good start! I've left some change requests. Please address them. Also consider using **kwargs parameter instead of defining all the arguments manually in function parameter list.
scribbles/apps/authentication/templates/authentication/login.html
Outdated
Show resolved
Hide resolved
scribbles/apps/authentication/templates/authentication/logout.html
Outdated
Show resolved
Hide resolved
scribbles/apps/authentication/templates/authentication/welcom.html
Outdated
Show resolved
Hide resolved
MillieNakiganda
force-pushed
the
ft-json-web-tokens-171110014
branch
from
6ad9f71 to
c8c5547
Compare
nkalyesubula
requested changes
Jul 19, 2020
Member
nkalyesubula
left a comment
nkalyesubula
left a comment
There was a problem hiding this comment.
Nice work Millie. A few remarks though;-
- Your authentication module is missing tests
- Your PR title should conform the one we agreed upon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
What are the relevant pivotal tracker stories?