[EXTERNAL] more-or-less Align with the exercise's test#2891
Merged
HarryVasanth merged 1 commit into01-edu:masterfrom Mar 24, 2025
Merged
[EXTERNAL] more-or-less Align with the exercise's test#2891HarryVasanth merged 1 commit into01-edu:masterfrom
more-or-less Align with the exercise's test#2891HarryVasanth merged 1 commit into01-edu:masterfrom
Conversation
HarryVasanth
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the exercise instructions with the existing tests by clarifying that
moreandlessmust take exactly one argument, whileaddandsubmust take exactly two. This ensures students write functions that pass the enforced tests of arguments in functions signatures:t(() => more.length === 1)t(() => less.length === 1)t(() => add.length === 2)t(() => sub.length === 2)Related PR: #2882
The tests are correct; it's the instructions that needed to be clearer to better align with them.