Conversation
MSilva95
requested changes
Jun 23, 2025
Member
MSilva95
left a comment
MSilva95
left a comment
There was a problem hiding this comment.
There is a conflict in the PR, I will continue the review, but in the meantime it needs to be fixed
MSilva95
requested changes
Jun 25, 2025
Member
MSilva95
left a comment
MSilva95
left a comment
There was a problem hiding this comment.
Apply the same things requested in module.
Contributor
Author
|
Conflict resolved. |
pedrodesu
commented
Jun 26, 2025
Contributor
Author
pedrodesu
left a comment
pedrodesu
left a comment
There was a problem hiding this comment.
Every comment/problem was addressed. Awaiting approval. Bear in mind the Prettier fail is (yet another!) false positive. It happens because we have the untrimmed empty space before newline on the diamond creation exercise again now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CON-3320