Skip to content

[EXTERNAL] Fix invalid use statement in example code modify_letter#2992

Merged
pedrodesu merged 2 commits into01-edu:masterfrom
BenaliOssama:fix-invalid-use-statement
Jun 26, 2025
Merged

[EXTERNAL] Fix invalid use statement in example code modify_letter#2992
pedrodesu merged 2 commits into01-edu:masterfrom
BenaliOssama:fix-invalid-use-statement

Conversation

@BenaliOssama
Copy link
Copy Markdown
Contributor

CON-#### | [EXTERNAL] Fix invalid use statement in example code


Why?

The Rust example code provided in the Usage section includes the following line:

use modify_letter::*modify_letter*;

This is invalid Rust syntax and causes a compile-time error.


Solution Overview

This pull request corrects the invalid use statement. The line:

use modify_letter::*modify_letter*;

was replaced with:

use modify_letter::*;

This version is valid and compiles correctly, allowing students to test the functions as intended.


Implementation Details

Only the import line was changed. No other logic or structure was modified.

Other approaches (like importing specific functions) were considered, but using use modify_letter::*; keeps the example simpler and matches the original intent of showing all functions in use.

@pedrodesu pedrodesu self-assigned this Jun 26, 2025
@pedrodesu pedrodesu added the 📕 Rust Rust label Jun 26, 2025
@pedrodesu pedrodesu self-requested a review June 26, 2025 13:47
Copy link
Copy Markdown
Contributor

@pedrodesu pedrodesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was exactly our intention - A minor mistake I've overlooked. Thank you so much for your contribution @BenaliOssama! Merging.

@pedrodesu pedrodesu merged commit 5c61e35 into 01-edu:master Jun 26, 2025
5 checks passed
@pedrodesu pedrodesu changed the title Fix invalid use statement in example code modify_letter [EXTERNAL] Fix invalid use statement in example code modify_letter Jun 26, 2025
@BenaliOssama BenaliOssama deleted the fix-invalid-use-statement branch June 26, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants