Skip to content

[EXTERNAL] Update README.md in ascii-art subject (typos in examples)#2994

Merged
MSilva95 merged 3 commits into01-edu:masterfrom
motonai:patch-1
Aug 6, 2025
Merged

[EXTERNAL] Update README.md in ascii-art subject (typos in examples)#2994
MSilva95 merged 3 commits into01-edu:masterfrom
motonai:patch-1

Conversation

@motonai
Copy link
Copy Markdown
Contributor

@motonai motonai commented Jun 29, 2025

Fixes typos in the examples given:

  • Fixes space length (6pixels+2 for separating chars) in examples that include space character
  • Fixes missing space after "2" char in "1Hello 2There" example

Why?

Misleads the student on what output should expect, especially if they use them for unit testing.

Solution Overview

Fixes the spaces

Implementation Details

Adds the spaces needed

Build Images

Not applicable... It's just a README.md

@sadiqui
Copy link
Copy Markdown
Contributor

sadiqui commented Jul 10, 2025

@motonai I agree with your PR except for the (6 pixels + 2 for separating chars) part.
Normally, it should be:

  • Add 1 missing whitespace after "o"
  • Plus 6 whitespaces (representation of one whitespace in the provided ASCII).

So the separating spaces should be (1 + 6) instead of (2 + 6).

Here is the corrected version:

student$ go run . "Hello There" | cat -e
 _    _          _   _                 _______   _                           $
| |  | |        | | | |               |__   __| | |                          $
| |__| |   ___  | | | |   ___            | |    | |__     ___   _ __    ___  $
|  __  |  / _ \ | | | |  / _ \           | |    |  _ \   / _ \ | '__|  / _ \ $
| |  | | |  __/ | | | | | (_) |          | |    | | | | |  __/ | |    |  __/ $
|_|  |_|  \___| |_| |_|  \___/           |_|    |_| |_|  \___| |_|     \___| $
                                                                             $
                                                                             $
student$ go run . "1Hello 2There" | cat -e
     _    _          _   _                         _______   _                           $
 _  | |  | |        | | | |                ____   |__   __| | |                          $
/ | | |__| |   ___  | | | |   ___         |___ \     | |    | |__     ___   _ __    ___  $
| | |  __  |  / _ \ | | | |  / _ \          __) |    | |    |  _ \   / _ \ | '__|  / _ \ $
| | | |  | | |  __/ | | | | | (_) |        / __/     | |    | | | | |  __/ | |    |  __/ $
|_| |_|  |_|  \___| |_| |_|  \___/        |_____|    |_|    |_| |_|  \___| |_|     \___| $
                                                                                         $
                                                                                         $
student$ go run . "{Hello There}" | cat -e
   __  _    _          _   _                 _______   _                           __    $
  / / | |  | |        | | | |               |__   __| | |                          \ \   $
 | |  | |__| |   ___  | | | |   ___            | |    | |__     ___   _ __    ___   | |  $
/ /   |  __  |  / _ \ | | | |  / _ \           | |    |  _ \   / _ \ | '__|  / _ \   \ \ $
\ \   | |  | | |  __/ | | | | | (_) |          | |    | | | | |  __/ | |    |  __/   / / $
 | |  |_|  |_|  \___| |_| |_|  \___/           |_|    |_| |_|  \___| |_|     \___|  | |  $
  \_\                                                                              /_/   $
                                                                                         $

@motonai
Copy link
Copy Markdown
Contributor Author

motonai commented Jul 10, 2025

I'll be pushing ASAP. You are correct, I forgot that last space column per letter is coming from the letter itself. Thank you for your feedback.

@motonai
Copy link
Copy Markdown
Contributor Author

motonai commented Jul 10, 2025

Seems ready now :)

@MSilva95 MSilva95 self-requested a review July 11, 2025 10:19
@Oumaimafisaoui Oumaimafisaoui requested review from MSilva95 and zanninso and removed request for MSilva95 and zanninso July 14, 2025 08:06
motonai added 3 commits August 6, 2025 17:25
Fixes typos in the examples given:
- Fixes space length (6pixels+2 for separating chars) in examples that include space character
- Fixes missing space after "2" char in "1Hello 2There" example
Copy link
Copy Markdown
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MSilva95 MSilva95 self-assigned this Aug 6, 2025
@MSilva95 MSilva95 merged commit 0eb00ba into 01-edu:master Aug 6, 2025
4 of 5 checks passed
@MSilva95 MSilva95 added the 🗂️ docs Documentation label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗂️ docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants