Skip to content

[EXTERNAL] added pub as it's expected from the import in main.rs#3003

Merged
pedrodesu merged 4 commits into01-edu:masterfrom
Ahmedelmalki:ahmed
Jul 28, 2025
Merged

[EXTERNAL] added pub as it's expected from the import in main.rs#3003
pedrodesu merged 4 commits into01-edu:masterfrom
Ahmedelmalki:ahmed

Conversation

@Ahmedelmalki
Copy link
Copy Markdown
Contributor

Before starting, please choose the relevant pull request Labels, Reviewers, and Assignees

Here are a couple of example tiles of a good pull request:

  • CON-1234 Title of The Feature or Fix
  • [EXTERNAL] Title of The Feature or Fix

CON-#### | [EXTERNAL]

Why?

Clearly state the reason for this change. What problem is it solving, or what feature is it adding?

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high-level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub-compliant mermaid graphs to represent the solution visually.

Implementation Details

Explain the details of the implementation and the reasoning behind it. What alternative approaches were considered, and why was this approach chosen?

Build Images

Please assign the label 📦 build If you want to re-build the following test images:

  • 💻 Sh
  • 🚀 JS
  • 🧩 DOM

@Ahmedelmalki
Copy link
Copy Markdown
Contributor Author

added pub as it's expected from the import in main.rs
fixed typo in to_string and removed struct declaration from main.rs

@pedrodesu pedrodesu self-requested a review July 28, 2025 10:36
@pedrodesu pedrodesu self-assigned this Jul 28, 2025
@pedrodesu pedrodesu added the 📕 Rust Rust label Jul 28, 2025
@pedrodesu
Copy link
Copy Markdown
Contributor

Hello @Ahmedelmalki Thank you for your PR. The changes look good and will be approved immediately.

@pedrodesu pedrodesu merged commit 4e92258 into 01-edu:master Jul 28, 2025
7 of 9 checks passed
@pedrodesu pedrodesu changed the title added pub as it\'s expected from the import in main.rs [EXTERNAL] added pub as it\'s expected from the import in main.rs Jul 28, 2025
@pedrodesu pedrodesu changed the title [EXTERNAL] added pub as it\'s expected from the import in main.rs [EXTERNAL] added pub as it's expected from the import in main.rs Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants