Skip to content

[EXTERNAL] docs(modify-letter): Changed to the correct output#3010

Merged
pedrodesu merged 2 commits into01-edu:masterfrom
ICEBergJQ:patch-1
Jul 31, 2025
Merged

[EXTERNAL] docs(modify-letter): Changed to the correct output#3010
pedrodesu merged 2 commits into01-edu:masterfrom
ICEBergJQ:patch-1

Conversation

@ICEBergJQ
Copy link
Copy Markdown
Contributor

output section the first out put should be "John" instead of "Joe"

Before starting, please choose the relevant pull request Labels, Reviewers, and Assignees

Here are a couple of example tiles of a good pull request:

  • CON-1234 Title of The Feature or Fix
  • [EXTERNAL] Title of The Feature or Fix

CON-#### | [EXTERNAL]

Why?

Clearly state the reason for this change. What problem is it solving, or what feature is it adding?

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high-level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub-compliant mermaid graphs to represent the solution visually.

Implementation Details

Explain the details of the implementation and the reasoning behind it. What alternative approaches were considered, and why was this approach chosen?

Build Images

Please assign the label 📦 build If you want to re-build the following test images:

  • 💻 Sh
  • 🚀 JS
  • 🧩 DOM

output section the first out put should be "John" instead of "Joe"
@ICEBergJQ ICEBergJQ closed this Jul 29, 2025
@ICEBergJQ ICEBergJQ deleted the patch-1 branch July 29, 2025 20:03
@ICEBergJQ ICEBergJQ restored the patch-1 branch July 29, 2025 20:04
@ICEBergJQ ICEBergJQ reopened this Jul 29, 2025
@ICEBergJQ ICEBergJQ changed the title Changed to the correct output in modify_letter/README.md docs(modify-letter): Changed to the correct output Jul 29, 2025
@pedrodesu
Copy link
Copy Markdown
Contributor

Hello @ICEBergJQ! Indeed this is an issue we've overlooked. Thank you for reaching out! I will approve the PR.

@pedrodesu pedrodesu self-assigned this Jul 31, 2025
@pedrodesu pedrodesu added the 📕 Rust Rust label Jul 31, 2025
@pedrodesu pedrodesu changed the title docs(modify-letter): Changed to the correct output [EXTERNAL] docs(modify-letter): Changed to the correct output Jul 31, 2025
@pedrodesu pedrodesu self-requested a review July 31, 2025 13:08
Copy link
Copy Markdown
Contributor

@pedrodesu pedrodesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pedrodesu pedrodesu merged commit b76edce into 01-edu:master Jul 31, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants