[EXTERNAL] docs(drawing): fix implementation example for rectangle#3013
Closed
sadiqui wants to merge 2 commits into01-edu:masterfrom
Closed
[EXTERNAL] docs(drawing): fix implementation example for rectangle#3013sadiqui wants to merge 2 commits into01-edu:masterfrom
drawing): fix implementation example for rectangle#3013sadiqui wants to merge 2 commits into01-edu:masterfrom
Conversation
Contributor
|
While technically squares classify as rectangles, I agree changing to a non-square example, the same as the one in the tests here makes sense. If you can, please run |
Contributor
|
Closed in favor of #3016. Includes this one change and has prettier all set up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Rectangle Implementation Example
This PR updates the example usage of the
Rectangleshape to correctly demonstrate a rectangle, rather than a square, as the original coordinates resulted in equal width and height.Changes:
Replaced:
with:
Note:
This corrected example is borrowed from the rust/tests repository.