Skip to content

[EXTERNAL] fix(numpy): clarify CSV header exclusion in instructions#3047

Merged
EldritchGriffin merged 4 commits into01-edu:masterfrom
vpollo11:fix-header-exclusion-numpy
Aug 28, 2025
Merged

[EXTERNAL] fix(numpy): clarify CSV header exclusion in instructions#3047
EldritchGriffin merged 4 commits into01-edu:masterfrom
vpollo11:fix-header-exclusion-numpy

Conversation

@vpollo11
Copy link
Copy Markdown
Member

Fix ambiguous instruction about row indexing

What changed

The sentence:

"Load the data using genfromtxt, specifying the delimiter as ';', and optimize the numpy array size by reducing the data types. Use np.float32 and verify that the resulting numpy array weighs 76800 bytes."

was unclear about whether the CSV header should be skipped or not.

It now says:

"Load the data using genfromtxt, specifying the delimiter as ';' with excluding the headers, and optimize the numpy array size by reducing the data types. Use np.float32 and verify that the resulting numpy array weighs 76800 bytes."

Why

Later instructions refer to specific row numbers (like the 2nd, 7th, and 12th rows). Without stating whether the header counts as a row, the meaning is ambiguous — it affects the indexing. This fix makes it clear that the header should be excluded.

No code changes

This is a documentation fix only.

…ng data

### Fix ambiguous instruction about row indexing

#### What changed

The sentence:

> "Load the data using genfromtxt, specifying the delimiter as ';', and optimize the numpy array size by reducing the data types. Use np.float32 and verify that the resulting numpy array weighs 76800 bytes."

was unclear about whether the CSV header should be skipped or not.

It now says:

> "Load the data using genfromtxt, specifying the delimiter as ';' with excluding the headers, and optimize the numpy array size by reducing the data types. Use np.float32 and verify that the resulting numpy array weighs 76800 bytes."

#### Why

Later instructions refer to specific row numbers (like the 2nd, 7th, and 12th rows). Without stating whether the header counts as a row, the meaning is ambiguous — it affects the indexing. This fix makes it clear that the header should be excluded.

#### No code changes

This is a documentation fix only.
[EXTERNAL] fix(numpy): clarify that CSV header is excluded when loading data
@vpollo11 vpollo11 changed the title fix(numpy): clarify CSV header exclusion in instructions [EXTERNAL] fix(numpy): clarify CSV header exclusion in instructions Aug 26, 2025
@EldritchGriffin EldritchGriffin self-assigned this Aug 28, 2025
@EldritchGriffin EldritchGriffin added the 🗂️ docs Documentation label Aug 28, 2025
Copy link
Copy Markdown
Member

@EldritchGriffin EldritchGriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@EldritchGriffin EldritchGriffin merged commit 441fb88 into 01-edu:master Aug 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗂️ docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants