Skip to content

[EXTERNAL] docs(matrix-factorization): add measurable validation, outputs, and performance checks to subject and audit#3094

Merged
Oumaimafisaoui merged 3 commits into01-edu:masterfrom
vpollo11:patch-19
Oct 15, 2025
Merged

[EXTERNAL] docs(matrix-factorization): add measurable validation, outputs, and performance checks to subject and audit#3094
Oumaimafisaoui merged 3 commits into01-edu:masterfrom
vpollo11:patch-19

Conversation

@vpollo11
Copy link
Copy Markdown
Member

Changes ✅ :

  • Added reproducibility and metric-saving requirements (RMSE, MAE, % improvement) under reports/model_metrics.json.
  • Added normalization and train/test split steps with random_state=42 for reproducibility.
  • Required saved artifacts:
    • reports/svd_predictions.npy
    • reports/pmf_convergence.png
    • reports/rmse_comparison.png
    • reports/predicted_vs_actual.png
    • reports/user__recommendations.csv
  • Defined performance thresholds:
    • SVD RMSE ≤ 0.90
    • PMF RMSE ≤ 0.85
    • PMF improvement ≥ 5%
  • Added Performance & Validation section to subject:
    • Includes expected metrics, visualization outputs, and fail conditions.
  • Updated audit with detailed checks:
    • File presence validation for models, utils, and reports.
    • Verification of saved plots, JSON metrics, and user recommendation files.
    • Runtime check for streamlit run app.py and error handling validation.
  • Ensured 1:1 alignment between subject and audit with explicit measurable outcomes.

@vpollo11 vpollo11 changed the title [EXTERNAL] feat(matrix-factorization): add measurable validation, outputs, and performance checks to subject and audit [EXTERNAL] docs(matrix-factorization): add measurable validation, outputs, and performance checks to subject and audit Oct 13, 2025
Copy link
Copy Markdown
Collaborator

@Oumaimafisaoui Oumaimafisaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oumaimafisaoui Oumaimafisaoui merged commit 9c9243a into 01-edu:master Oct 15, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants