Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a minimum interval cap for pool idle connection cleanup to improve performance by preventing excessive wake-ups for very short idle intervals. It's a backport from hyper-util that addresses potential performance issues when users configure very short idle timeouts.
- Adds a 90ms minimum check interval for pool idle connection eviction
- Updates the idle interval calculation to respect this minimum while still honoring shorter durations at checkout time
- Modifies existing tests to validate the new minimum interval behavior
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport: hyperium/hyper-util@24714a3