Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames connector types and variables to follow more consistent naming conventions for proxy connectors. The changes improve code clarity by using more descriptive names that better indicate the purpose of each component.
- Renamed
TunneltoTunnelConnectorandSockstoSocksConnectorfor consistency - Renamed
SocksVersiontoVersionto reduce redundancy - Updated variable names like
proxytoproxy_dstfor better clarity
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core/client/connect/proxy/tunnel.rs | Renamed Tunnel struct to TunnelConnector and updated documentation |
| src/core/client/connect/proxy/socks.rs | Renamed Socks to SocksConnector, SocksVersion to Version, and updated parameter names |
| src/core/client/connect/proxy/mod.rs | Updated public exports to reflect the new type names |
| src/connect.rs | Updated imports and usage of renamed types throughout the connector implementation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.