Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an encoding issue with TLS ALPS (Application-Layer Protocol Settings) extensions when multiple protocols are present. The fix changes from concatenating all ALPS protocol values into a single byte sequence to properly handling each protocol individually through separate calls to the underlying TLS library.
Key changes:
- Removes the
encode_sequencemethod that was incorrectly concatenating ALPS protocol values - Adds individual handling of each ALPS protocol through separate
add_application_settingscalls - Refactors the API to pass protocol collections directly rather than pre-encoded byte sequences
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tls/types.rs | Removes encode_sequence method and adds value() accessor for individual protocol values |
| src/tls/conn/mod.rs | Updates method calls to use new ALPS and ALPN protocol handling APIs |
| src/tls/conn/ext.rs | Implements proper individual handling of ALPS protocols and adds ALPN protocol handling |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.