Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DNS module by making the hickory DNS resolver internal and simplifying its API. The changes consolidate DNS configuration by removing the custom LookupIpStrategy enum and defaulting to a fixed strategy.
- Simplifies the hickory DNS resolver by removing configurable lookup strategies and using a fixed
Ipv4AndIpv6strategy - Changes module visibility to make internal DNS modules private to the crate (
pub(crate)) - Replaces
Arc<TokioResolver>with a staticLazyLock<TokioResolver>for better resource management
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/core/client/connect/dns/mod.rs | Changes module visibility from public to crate-internal |
| src/core/client/connect/dns/hickory.rs | Removes custom LookupIpStrategy enum and simplifies resolver construction |
| src/client/http/mod.rs | Updates resolver instantiation to use the simplified API |
0x676e67
marked this pull request as ready for review
August 9, 2025 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.