Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the DNS resolver module by introducing a more ergonomic trait-based API (IntoResolve) that enables easier conversion of various resolver types into the expected Arc<dyn Resolve> format. The changes simplify the user experience when working with DNS resolvers by providing automatic conversions and removing the need for explicit Arc wrapping or error handling for domain name parsing.
- Introduced
IntoResolvetrait for ergonomic conversion of resolver types toArc<dyn Resolve> - Replaced fallible
FromStrimplementation forNamewith infallibleFrom<&str>implementation - Updated API signatures to accept generic resolver types through the new trait
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/core/client/connect/dns/resolve.rs |
Removes error-based domain parsing, adds IntoResolve trait with implementations, replaces FromStr with From<&str> for Name |
src/core/client/connect/dns/mod.rs |
Exports the new IntoResolve trait for public API usage |
src/core/client/connect/dns/gai.rs |
Updates test code to use the new From<&str> implementation instead of FromStr |
src/client/http/mod.rs |
Updates dns_resolver method to use generic IntoResolve parameter and improves comment consistency |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.