Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the ergonomics and flexibility of cookie providers by introducing a new IntoCookieStore trait that enables automatic conversion of various cookie store types. The main purpose is to make the cookie_provider API more user-friendly by accepting different types of cookie stores without requiring manual Arc wrapping.
- Introduces
IntoCookieStoretrait with implementations forCookieStore,Arc<T>, andArc<dyn CookieStore> - Updates
cookie_providermethod to accept any type implementingIntoCookieStore - Includes a minor documentation fix for the DNS resolver method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cookie.rs | Adds IntoCookieStore trait and implementations for ergonomic cookie store conversion |
| src/client/http/mod.rs | Updates cookie_provider method signature and fixes DNS resolver documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.