Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes HTTP/1 header writing by eliminating intermediate header sorting and memory allocations. Instead of first sorting headers into a new HeaderMap and then iterating through them, the new approach directly writes headers during the sorting iteration process.
- Introduces a new
sort_headers_for_eachmethod that combines sorting and iteration into a single operation - Replaces the
write_headers_original_casefunction to use the new approach, removing the need for intermediate header storage - Refactors control flow in client response parsing for better readability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/header.rs | Adds sort_headers_for_each method and moves test helper function from public to test module |
| src/core/client/proto/h2/client.rs | Updates variable naming for clarity (orig → orig_headers) |
| src/core/client/proto/h1/role.rs | Refactors header writing to use new streaming approach and improves control flow structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.