Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Unix domain socket connections to the HTTP client, enabling communication through local sockets instead of TCP/IP. This is particularly useful for communicating with services like Docker daemon or other local services that expose APIs over Unix sockets.
Key changes include:
- Implementation of Unix socket connection support with
UnixConnectorand related types - Extension of client builder and request builder APIs to accept Unix socket paths
- TLS support over Unix domain sockets for secure local communication
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/client/service/meta.rs | Adds Unix socket options accessor to connection metadata |
| src/core/client/options/mod.rs | Extends request options to include Unix connection configuration |
| src/core/client/connect/uds.rs | Implements core Unix domain socket connector functionality |
| src/core/client/connect/mod.rs | Exports Unix socket types and reorganizes module structure |
| src/client/request.rs | Adds unix_socket() method to request builder API |
| src/client/http/mod.rs | Integrates Unix socket support into main client configuration |
| src/client/http/connect/uds.rs | Provides ergonomic conversion trait for Unix socket paths |
| src/client/http/connect/tls_info.rs | Extends TLS info support for Unix streams |
| src/client/http/connect/mod.rs | Exposes Unix domain socket module |
| src/client/http/connect/connector.rs | Core connector logic for Unix socket connections with TLS |
| src/client/http/connect/conn.rs | Connection trait implementations for Unix streams |
| examples/unix_socket.rs | Demonstrates Unix socket usage with Docker API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.