Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors legacy unsafe wrapper code in the HTTP/2 implementation by removing unsafe memory transmutation patterns and simplifying the type system. The changes eliminate the UpgradedSendStream wrapper and its associated unsafe Neutered type, replacing them with direct usage of the underlying SendStream type.
- Removes unsafe memory transmutation code in
UpgradedSendStreamandNeuteredtypes - Updates function calls to use
send_datainstead of the wrapper'swritemethod - Adds
Sendtrait bounds to ensure type safety without unsafe code
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/lib.rs | Adds commented deny directive for unsafe code |
| src/core/client/proto/h2/mod.rs | Removes unsafe wrapper types and updates method calls |
| src/core/client/proto/h2/client.rs | Updates type usage and adds Send trait bounds |
| src/core/client/dispatch.rs | Adds Send trait bound for body data |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.