Skip to content

chore(deps): replace base64 with boring2::base64 - #910

Merged
0x676e67 merged 1 commit into
mainfrom
base64
Aug 21, 2025
Merged

chore(deps): replace base64 with boring2::base64#910
0x676e67 merged 1 commit into
mainfrom
base64

Conversation

@0x676e67

Copy link
Copy Markdown
Owner

On my machine, the boring2 base64 encoding implementation benchmarks faster than Rust’s base64. Replacing the implementation also reduces crate dependencies, which shortens compile time.

@0x676e67
0x676e67 requested a review from Copilot August 21, 2025 23:39
@0x676e67
0x676e67 marked this pull request as ready for review August 21, 2025 23:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the base64 crate dependency with boring2::base64 for base64 encoding operations to improve performance and reduce compilation dependencies.

  • Removes the base64 crate dependency from Cargo.toml
  • Updates the basic_auth function implementation to use boring2::base64::encode_block
  • Changes the function visibility from pub to pub(crate) and refactors the encoding logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/util.rs Replaces base64 encoding implementation and updates function visibility
Cargo.toml Removes base64 crate dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/util.rs
Comment thread src/util.rs
@0x676e67
0x676e67 merged commit 3d6c116 into main Aug 21, 2025
18 checks passed
@0x676e67
0x676e67 deleted the base64 branch August 21, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants