Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the base64 crate dependency with boring2::base64 for base64 encoding operations to improve performance and reduce compilation dependencies.
- Removes the
base64crate dependency from Cargo.toml - Updates the
basic_authfunction implementation to useboring2::base64::encode_block - Changes the function visibility from
pubtopub(crate)and refactors the encoding logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/util.rs | Replaces base64 encoding implementation and updates function visibility |
| Cargo.toml | Removes base64 crate dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my machine, the boring2 base64 encoding implementation benchmarks faster than Rust’s base64. Replacing the implementation also reduces crate dependencies, which shortens compile time.