Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability for custom redirect policies to access response headers from redirect attempts. The main purpose is to allow developers to make more informed decisions during redirects by examining headers such as cache-control, set-cookie, or custom headers from the redirect response.
- Added headers field to the
Attemptstruct in both redirect modules - Updated all redirect policy interfaces to pass and expose headers
- Refactored code organization by moving helper functions and adding const qualifiers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/redirect.rs | Added headers field to Attempt struct, updated Policy check method signature, and reorganized helper functions |
| src/client/layer/redirect/policy.rs | Added headers field and accessor method to policy Attempt struct |
| src/client/layer/redirect/future.rs | Updated Attempt construction to include response headers |
| examples/request_with_redirect.rs | Updated example to demonstrate accessing headers in custom redirect policy |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.