Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Conversation

@yanick
Copy link
Contributor

@yanick yanick commented Nov 12, 2019

... that is, if {emojy: true} is enabled.

... that is, if `{emojy: true}` is enabled.
@0x80
Copy link
Owner

0x80 commented Jan 22, 2020

@yanick If you want to emojify allthethings then I think you need to adapt the writeOnNthLine function as well. It is used by the spinner.

And I guess warnings and errors are also a candidate. They write directly to stderr.

Please also check what happens in CI environments. I think the emojis should be disabled there probably. You could test this by setting the CI environment variable when running the examples.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants